Page MenuHomePhorge

Fix call to non-existing newWorkCommands() in NuanceItemType
Needs ReviewPublic

Authored by aklapper on Fri, May 17, 09:09.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 1, 10:35
Unknown Object (File)
Fri, May 31, 12:58
Unknown Object (File)
Fri, May 31, 03:27
Unknown Object (File)
Thu, May 30, 13:42
Unknown Object (File)
Tue, May 28, 14:15
Unknown Object (File)
Wed, May 22, 23:46
Unknown Object (File)
Wed, May 22, 22:38
Unknown Object (File)
Wed, May 22, 21:50

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

rPe1b8532e2478395bd1f36baecb998adeef5bea3d introduced an implementation of newWorkCommands() in the child class NuanceFormItemType which is called in parent NuanceItemType::buildWorkCommands() without being defined in that parent class.
Thus define newWorkCommands() as an abstract class in parent class NuanceItemType and add an implementation returning null in the other child class NuanceGitHubEventItemType to make static code analyzers happy.

Test Plan

Carefully read the code.

Diff Detail

Repository
rP Phorge
Branch
NEnuanceNewWorkCommands (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1278
Build 1278: arc lint + arc unit