User Details
- User Since
- Jun 10 2021, 05:36 (155 w, 3 d)
- Roles
- Administrator
- Availability
- Available
- Timezone
- UTC+2
Today
I think the EditEngine is what's used to create the actions form, and it has some sense of the object's status (see for example the available actions on Revisions - these change based on the revision's state).
Maybe it can get an additional "field" for this warning, and display it based on task status.
Wed, May 29
Very cool!
Don't we have something like phutil_is_integer method somewhere?
Sun, May 26
Sat, May 25
This is spelling, not formatting.
Using a password in 2024 is a bad advice in general.
Tue, May 21
need to also test the result of renderPhabricatorLogo() when no logo set, when a custom logo is set, and when a custom logo is set but hidden (maybe. Maybe the logo file should be Attached to something public, so this situation can't really happen?)
That "don't sign a CLA" article should be titled "don't sign away your copyrights", to be more accurate and less click-bait-y. A CLA may ask you to sign away copyrights (which I feel makes the project non-open-source) ; It doesn't have to.
Sun, May 19
Tue, May 14
(It's about spam, but it doesn't have anything explicitly sensitive. I've made it public now)
Sun, May 12
On a more meta level, Maniphest isn't well-suited to be an entry-form to be filled by a non-expert user; Nuance is/was intended for this use-case.
on the technical level, Herald can't block object creation - it runs after the fact, by the Daemons.
I think the 404 is possibly better then "silently fail without error".
How can we end up with null here?
Sat, May 11
Rebase
Thu, May 9
Wed, May 8
(run the full tests, and then count it as my + O1 Accept).
I think the costs of the extra translations are low, but the cost of "the tests are not being translated for developers" are even lower.
I'd be worried that this might break some tests that do relate to translation/extraction, but running arc unit --everything should solve that.
Sun, May 5
This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).
Apr 29 2024
You can set "visibility" for each URI already.
Apr 28 2024
Yeah, thad makes sense, I guess.
- check for non-null repository in Revision
- rebase
Apr 27 2024
Pending that small inline, lgtm.
Apr 26 2024
Can't reproduce either - 🤷🏻♂️
Apr 25 2024
Done - #ponder now refers to the new (active) tag.
Apr 24 2024
I thought we had a ticket for "allow more things to show up in workboards", but I can't find it.
Apr 16 2024
Apr 15 2024
done...
Yeah, probably. I'll try to do it tonight.
Apr 14 2024
Maybe put the warning above the box, so it catches all actions, not just comments?
Unless we can come up with a better/more common notation to show this information, I'm +1 on this - I like static type information, and this one looks fine to me.
I'm not familiar with many PHP tools - is there another notation somewhere?
Apr 12 2024
Apr 11 2024
Apr 10 2024
Done:
Apr 9 2024
Apr 5 2024
Did that Phactory: Hosting Projects Here
This script can be used to download the entire graph:
It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)
Doesn't actually work for me either after arc patch:
Apr 4 2024
We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.
- Don't exist in Diffusion
- Do exist in Paste
- Don't exist in Differential
There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.
You should be able to just arc land this now...
I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").
Apr 3 2024
As a work-around, you can probably add ?offset=0 to the URL.
(The images aren't public/attached, so I can't see them)
All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷♂️
See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.
Apr 2 2024
@kat: I've added you to the Trusted Contributors project, so you can now land this change!