Paths

Table of Contentst

-
src/
-
__phutil_library_map__.php
-
applications/
-
audit/editor/
-
editor/
-
PhabricatorAuditCommentEditor.php
-
base/controller/
-
controller/
-
PhabricatorController.php
-
conpherence/
-
controller/
-
ConpherenceNewController.php
-
query/
-
ConpherenceThreadQuery.php
-
countdown/query/
-
query/
-
PhabricatorCountdownSearchEngine.php
-
differential/
-
conduit/
-
ConduitAPI_differential_getcommitmessage_Method.php
-
ConduitAPI_differential_getrevision_Method.php
-
editor/
-
DifferentialCommentEditor.php
-
DifferentialRevisionEditor.php
-
events/
-
DifferentialHovercardEventListener.php
-
field/specification/
-
specification/
-
DifferentialArcanistProjectFieldSpecification.php
-
DifferentialCommitsFieldSpecification.php
-
DifferentialManiphestTasksFieldSpecification.php
-
DifferentialReviewersFieldSpecification.php
-
mail/
-
DifferentialCommentMail.php
-
DifferentialMail.php
-
query/
-
DifferentialRevisionSearchEngine.php
-
search/
-
DifferentialSearchIndexer.php
-
diffusion/
-
doorkeeper/
-
DiffusionDoorkeeperCommitFeedStoryPublisher.php
-
events/
-
DiffusionHovercardEventListener.php
-
files/query/
-
query/
-
PhabricatorFileSearchEngine.php
-
flag/
-
conduit/
-
ConduitAPI_flag_Method.php
-
controller/
-
PhabricatorFlagEditController.php
-
herald/
-
adapter/
-
HeraldAdapter.php
-
query/
-
HeraldRuleSearchEngine.php
-
legalpad/query/
-
query/
-
LegalpadDocumentSearchEngine.php
-
lipsum/management/
-
management/
-
PhabricatorLipsumGenerateWorkflow.php
-
macro/query/
-
query/
-
PhabricatorMacroSearchEngine.php
-
maniphest/
-
ManiphestTaskQuery.php
-
controller/
-
ManiphestController.php
-
ManiphestTaskListController.php
-
editor/
-
ManiphestTransactionEditor.php
-
event/
-
ManiphestHovercardEventListener.php
-
search/
-
ManiphestSearchIndexer.php
-
metamta/
-
management/
-
PhabricatorMailManagementListInboundWorkflow.php
-
replyhandler/
-
PhabricatorMailReplyHandler.php
-
owners/mail/
-
mail/
-
PackageMail.php
-
PackageModifyMail.php
-
paste/query/
-
query/
-
PhabricatorPasteSearchEngine.php
-
phame/
-
controller/
-
blog/
-
PhameBlogFeedController.php
-
post/
-
PhamePostEditController.php
-
skins/
-
PhameBasicBlogSkin.php
-
storage/
-
PhameBlog.php
-
phid/
-
PhabricatorObjectHandle.php
-
conduit/
-
ConduitAPI_phid_info_Method.php
-
ConduitAPI_phid_lookup_Method.php
-
ConduitAPI_phid_query_Method.php
-
handle/
-
PhabricatorObjectHandleData.php
-
pholio/
-
controller/
-
PholioMockEditController.php
-
query/
-
PholioMockSearchEngine.php
-
phrequent/controller/
-
controller/
-
PhrequentListController.php
-
policy/
-
filter/
-
PhabricatorPolicyFilter.php
-
query/
-
PhabricatorPolicyQuery.php
-
ponder/query/
-
query/
-
PonderQuestionSearchEngine.php
-
project/query/
-
query/
-
PhabricatorProjectSearchEngine.php
-
releeph/
-
conduit/
-
ConduitAPI_releeph_request_Method.php
-
work/
-
ConduitAPI_releephwork_getbranch_Method.php
-
ConduitAPI_releephwork_getbranchcommitmessage_Method.php
-
ConduitAPI_releephwork_nextrequest_Method.php
-
controller/
-
branch/
-
ReleephBranchEditController.php
-
project/
-
ReleephProjectEditController.php
-
editor/
-
ReleephBranchEditor.php
-
field/specification/
-
specification/
-
ReleephIntentFieldSpecification.php
-
ReleephRequestorFieldSpecification.php
-
query/
-
ReleephRequestSearchEngine.php
-
storage/
-
ReleephBranch.php
-
view/user/
-
user/
-
ReleephUserView.php
-
repository/worker/
-
worker/
-
PhabricatorRepositoryCommitHeraldWorker.php
-
commitmessageparser/
-
PhabricatorRepositoryCommitMessageParserWorker.php
-
search/
-
controller/
-
PhabricatorSearchAttachController.php
-
PhabricatorSearchController.php
-
PhabricatorSearchHovercardController.php
-
engine/
-
PhabricatorSearchEngineElastic.php
-
slowvote/
-
query/
-
PhabricatorSlowvoteSearchEngine.php
-
view/
-
SlowvoteEmbedView.php
-
subscriptions/
-
controller/
-
PhabricatorSubscriptionsEditController.php
-
events/
-
PhabricatorSubscriptionsUIEventListener.php
-
tokens/
-
controller/
-
PhabricatorTokenGiveController.php
-
PhabricatorTokenGivenController.php
-
PhabricatorTokenLeaderController.php
-
editor/
-
PhabricatorTokenGivenEditor.php
-
event/
-
PhabricatorTokenUIEventListener.php
-
query/
-
PhabricatorTokenGivenQuery.php
-
PhabricatorTokenReceiverQuery.php
-
transactions/
-
controller/
-
PhabricatorApplicationTransactionCommentEditController.php
-
PhabricatorApplicationTransactionCommentHistoryController.php
-
editor/
-
PhabricatorApplicationTransactionEditor.php
-
query/
-
PhabricatorApplicationTransactionQuery.php
-
uiexample/examples/
-
examples/
-
PHUIObjectItemListExample.php
-
PhabricatorTimelineExample.php
-
infrastructure/edges/query/
-
edges/
-
query/
-
PhabricatorEdgeQuery.php

Diffusion Phorge b902005bed52

Kill PhabricatorObjectDataHandle
b902005bed52
Actions

Description

Kill PhabricatorObjectDataHandle

Summary: Ref T603. Killing this class is cool because the classes that replace it are policy-aware. Tried to keep my wits about me as I did this and fixed a few random things along the way. (Ones I remember right now are pulling a query outside of a foreach loop in Releeph and fixing the text in UIExample to note that the ace of hearts if "a powerful" card and not the "most powerful" card (Q of spades gets that honor IMO))

Test Plan: tested the first few changes (execute, executeOne X handle, object) then got real mechanical / careful with the other changes.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran, FacebookPOC

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6941

Details

Provenance

Bob Trahan

Authored on Sep 11 2013, 19:27

Parents

rP07b8becfc6d5: Policy - introduce parentQuery and pass around policy configuration from parent…

Branches

Tags

Event Timeline

aklapper mentioned this in D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.Nov 28 2024, 11:40

Changes (92)

Path

Size

Packages

src/

Kill PhabricatorObjectDataHandleb902005bed52Actions

Description

Details

Event Timeline

Changes (92)

rPb902005bed52

src/__phutil_library_map__.php

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

src/applications/base/controller/PhabricatorController.php

src/applications/conpherence/controller/ConpherenceNewController.php

src/applications/conpherence/query/ConpherenceThreadQuery.php

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

src/applications/differential/conduit/ConduitAPI_differential_getrevision_Method.php

src/applications/differential/editor/DifferentialCommentEditor.php

src/applications/differential/editor/DifferentialRevisionEditor.php

src/applications/differential/events/DifferentialHovercardEventListener.php

src/applications/differential/field/specification/DifferentialArcanistProjectFieldSpecification.php

src/applications/differential/field/specification/DifferentialCommitsFieldSpecification.php

src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php

src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php

src/applications/differential/mail/DifferentialCommentMail.php

src/applications/differential/mail/DifferentialMail.php

src/applications/differential/query/DifferentialRevisionSearchEngine.php

src/applications/differential/search/DifferentialSearchIndexer.php

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

src/applications/diffusion/events/DiffusionHovercardEventListener.php

src/applications/files/query/PhabricatorFileSearchEngine.php

src/applications/flag/conduit/ConduitAPI_flag_Method.php

src/applications/flag/controller/PhabricatorFlagEditController.php

src/applications/herald/adapter/HeraldAdapter.php

src/applications/herald/query/HeraldRuleSearchEngine.php

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

src/applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php

src/applications/macro/query/PhabricatorMacroSearchEngine.php

src/applications/maniphest/ManiphestTaskQuery.php

src/applications/maniphest/controller/ManiphestController.php

src/applications/maniphest/controller/ManiphestTaskListController.php

src/applications/maniphest/editor/ManiphestTransactionEditor.php

src/applications/maniphest/event/ManiphestHovercardEventListener.php

src/applications/maniphest/search/ManiphestSearchIndexer.php

src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

src/applications/owners/mail/PackageMail.php

src/applications/owners/mail/PackageModifyMail.php

src/applications/paste/query/PhabricatorPasteSearchEngine.php

src/applications/phame/controller/blog/PhameBlogFeedController.php

src/applications/phame/controller/post/PhamePostEditController.php

src/applications/phame/skins/PhameBasicBlogSkin.php

src/applications/phame/storage/PhameBlog.php

src/applications/phid/PhabricatorObjectHandle.php

src/applications/phid/conduit/ConduitAPI_phid_info_Method.php

src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php

src/applications/phid/conduit/ConduitAPI_phid_query_Method.php

src/applications/phid/handle/PhabricatorObjectHandleData.php

src/applications/pholio/controller/PholioMockEditController.php

src/applications/pholio/query/PholioMockSearchEngine.php

src/applications/phrequent/controller/PhrequentListController.php

src/applications/policy/filter/PhabricatorPolicyFilter.php

src/applications/policy/query/PhabricatorPolicyQuery.php

src/applications/ponder/query/PonderQuestionSearchEngine.php

src/applications/project/query/PhabricatorProjectSearchEngine.php

src/applications/releeph/conduit/ConduitAPI_releeph_request_Method.php

src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranch_Method.php

src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php

src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php

src/applications/releeph/controller/branch/ReleephBranchEditController.php

src/applications/releeph/controller/project/ReleephProjectEditController.php

src/applications/releeph/editor/ReleephBranchEditor.php

src/applications/releeph/field/specification/ReleephIntentFieldSpecification.php

src/applications/releeph/field/specification/ReleephRequestorFieldSpecification.php

src/applications/releeph/query/ReleephRequestSearchEngine.php

src/applications/releeph/storage/ReleephBranch.php

src/applications/releeph/view/user/ReleephUserView.php

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

src/applications/search/controller/PhabricatorSearchAttachController.php

src/applications/search/controller/PhabricatorSearchController.php

src/applications/search/controller/PhabricatorSearchHovercardController.php

src/applications/search/engine/PhabricatorSearchEngineElastic.php

Kill PhabricatorObjectDataHandle
b902005bed52
Actions