Page MenuHomePhorge

nib (Nick Belyavski)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 4 2024, 06:04 (24 w, 2 d)
Availability
Available

Recent Activity

Mon, May 19

nib added a comment to D25872: Implements arc work for git workflow.

P.S. Uh, I noticed that arc work also has a --start parameter! I documented a bit the expected behavior in the task T15993.

So that parameter is currently not supported for tasks, maybe relevant for the patch author:

$ arc work --start stable T15993
 NEW BRANCH  Creating new branch "T15993-support-for-arc-work-t12345-(workontask-workflow)" from "master".
 BRANCH  Checking out branch "T15993-support-for-arc-work-t12345-(workontask-workflow)".

So you see that from "master" that means we are not supporting --start, I guess.

If we cannot add support to that, we can add another cute TODO-exception for this corner case I guess (and create another task I guess)

Mon, May 19, 09:45

Sun, May 18

nib added a comment to D25872: Implements arc work for git workflow.

P.S. Uh, I noticed that arc work also has a --start parameter! I documented a bit the expected behavior in the task T15993.

So that parameter is currently not supported for tasks, maybe relevant for the patch author:

$ arc work --start stable T15993
 NEW BRANCH  Creating new branch "T15993-support-for-arc-work-t12345-(workontask-workflow)" from "master".
 BRANCH  Checking out branch "T15993-support-for-arc-work-t12345-(workontask-workflow)".

So you see that from "master" that means we are not supporting --start, I guess.

If we cannot add support to that, we can add another cute TODO-exception for this corner case I guess (and create another task I guess)

Sun, May 18, 07:47
nib added a comment to D25872: Implements arc work for git workflow.

Tested for T15100 and T15993 and I'm a bit surprised to obtain, this very long branch with commas and square brackets (and just the closing bracket? uhm)

T15100-feature-request]-option-to-measure-wip-limits-based-on-card-count-instead-of-points,-to-more-closely-adhere-to-kanban-standards

and this with round brackets (that is not Bash friendly for the git autocomplete):

T15993-support-for-arc-work-t12345-(workontask-workflow)

Probably here we should normalize a bit more these branch names. To do it, I see that Phorge already has a "normalize" method that does great things, but unfortunately it's not available in Arcanist (we cannot call it, or we create a circular dependency)...

https://we.phorge.it/source/phorge/browse/master/src/infrastructure/util/PhabricatorSlug.php

What do you think about? Should we import a very minimal "ArcanistSlug" class? And now/then having PhabricatorSlug extending that? (to give 100% backward compatibility but uniform code)

I'm a bit unsure. Thanks for opinions.

Sun, May 18, 01:31

Apr 7 2025

nib added a comment to Q173: Why do Milestones in parent project's Workboard seemingly randomly hide tasks?.

I patched this in our local repo with a change to /src/applications/project/engine/PhabricatorBoardLayoutEngine.php, in the layoutBoard() method. Around line 520, inside if ($proxy_hits) block, you have array_slice() taking the first element of $proxy_hits, which seems random.

Apr 7 2025, 23:54

Mar 17 2025

nib added a comment to D25872: Implements arc work for git workflow.
In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

Probably yes so it's easier with Subversion and Mercurial in the future (?)

Probably something with "for task" in the name like buildBranchNameForTask($task_ref)

Mar 17 2025, 08:12
nib updated the diff for D25872: Implements arc work for git workflow.
  • Handle arc work for new and existing git branches
Mar 17 2025, 07:30
nib updated the diff for D25872: Implements arc work for git workflow.

Handle arc work for new and existing git branches

Mar 17 2025, 06:38

Feb 20 2025

nib added a comment to D25872: Implements arc work for git workflow.

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

Feb 20 2025, 11:33
nib added a comment to D25872: Implements arc work for git workflow.

Hopefully the latest change will work for you. Now it checks existing git branches matching "T12345*" and if any exist, it will git checkout the first one, else it will create it from the task name.
So that should allow you to change the task title, and to use arc work T12345 as many times as you want without error.

Feb 20 2025, 11:24
nib updated the diff for D25872: Implements arc work for git workflow.
  • Fix indents, adds emoji support, improve REGEX
  • Detect existing branch for task
Feb 20 2025, 11:19
nib updated the diff for D25872: Implements arc work for git workflow.
  • Handles existing branches
  • Fixes indents, adds emoji support, improves REGEX
Feb 20 2025, 11:14
nib updated the diff for D25872: Implements arc work for git workflow.

Fixes error when invoking arc work 2nd time on task id

Feb 20 2025, 09:08

Feb 18 2025

nib updated the diff for D25872: Implements arc work for git workflow.
  • Fixes indents, adds emoji support, improves REGEX
Feb 18 2025, 09:24

Feb 13 2025

nib added a revision to T15993: Support for arc work T12345 (workOnTask workflow): D25872: Implements arc work for git workflow.
Feb 13 2025, 05:07 · Arcanist
nib requested review of D25872: Implements arc work for git workflow.
Feb 13 2025, 05:07