In D25872#23862, @valerio.bozzolan wrote:

In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

Probably yes so it's easier with Subversion and Mercurial in the future (?)

Probably something with "for task" in the name like buildBranchNameForTask($task_ref)

• Handle arc work for new and existing git branches

Handle arc work for new and existing git branches

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

Hopefully the latest change will work for you. Now it checks existing git branches matching "T12345*" and if any exist, it will git checkout the first one, else it will create it from the task name.
So that should allow you to change the task title, and to use arc work T12345 as many times as you want without error.

• Fix indents, adds emoji support, improve REGEX
• Detect existing branch for task

• Handles existing branches
• Fixes indents, adds emoji support, improves REGEX

Fixes error when invoking arc work 2nd time on task id

• Fixes indents, adds emoji support, improves REGEX