Improving UX for ignoring timezone conflicts
Back to Revision

Inline Comments

Diff	Reviewer	Comment	Created
Diff 1343	avivey	Can probably just use `phutil_tag('strong', array(), 'OR')` here.	72 w
Diff 1343	avivey	Or maybe make "Or" be the label for the checkbox (would show up under "New Setting").	72 w
Diff 1343	avivey	Default to //unchecked//, and align the indentation.	72 w
Diff 1345	valerio.bozzolan	@avivey Should we drop this line?	72 w
Diff 1345	avivey	🤷‍♀️	72 w
Diff 1345	valerio.bozzolan	xD @roberto.urbani If you want, this is a nice moment for you to decide whenever to keep this option, or just set as an empty array. Don't worry, in both cases someone out there in the planet will be furious. Feel free to roll a dice to decide.	72 w
Diff 1345	avivey	Our style-guide says that if the call doesn't fit in a single line, then //all// arguments should be on individual lines: ``` $current_zone_formatted = phutil_tag( 'strong', 'array()', $current_zone_identifier); ```	72 w