Differential D25029 Diff 78 src/repository/api/ArcanistGitAPI.php

Changeset View

Standalone View

src/repository/api/ArcanistGitAPI.php

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines	if (!strlen($info)) {
return array();		return array();
}		}

$info = explode("\2", $info);		$info = explode("\2", $info);
foreach ($info as $line) {		foreach ($info as $line) {
list($commit, $tree, $parents, $time, $author, $author_email,		list($commit, $tree, $parents, $time, $author, $author_email,
$title, $message) = explode("\1", trim($line), 8);		$title, $message) = explode("\1", trim($line), 8);
$message = rtrim($message);		$message = rtrim($message);
		$co_authors = array();

		foreach (explode("\n", $message) as $line) {
		Lint: Reuse of Iterator Variable Inline Actions This loop reuses iterator variables ($line) from an outer loop. You might be clobbering the outer iterator. Change the inner loop to use a different iterator name. Lint: Reuse of Iterator Variable: This loop reuses iterator variables ($line) from an outer loop. You might be clobbering the…
		if (stripos($line, 'Co-authored-by:') !== 0) {
		Lint: Slow Construct Inline Actions Use `strncasecmp` for checking if the string starts with something. Lint: Slow Construct: Use `strncasecmp` for checking if the string starts with something.
		continue;
		}

		$matches = array();
		$status = preg_match('/^co-authored-by:\s(.)<(.*)>/i', $line, $matches);
		Lint: Line Too Long Inline Actions This line is 82 characters long, but the convention is 80 characters. Lint: Line Too Long: This line is 82 characters long, but the convention is 80 characters.

		if ($status !== 1) {
		continue;
		}

		$co_authors[] = array(
		'name' => $matches[1],
		'email' => $matches[2],
		);
		}

$commits[$commit] = array(		$commits[$commit] = array(
'commit' => $commit,		'commit' => $commit,
'tree' => $tree,		'tree' => $tree,
'parents' => array_filter(explode(' ', $parents)),		'parents' => array_filter(explode(' ', $parents)),
'time' => $time,		'time' => $time,
'author' => $author,		'author' => $author,
'summary' => $title,		'summary' => $title,
'message' => $message,		'message' => $message,
'authorEmail' => $author_email,		'authorEmail' => $author_email,
		'coAuthors' => $co_authors,
		aviveyUnsubmitted Not Done Inline Actions Looks like we already upload the entire commit message - can we do this logic in the server, avoiding adding this key to the API? avivey: Looks like we already upload the entire commit message - can we do this logic in the server…
);		);
}		}

return $commits;		return $commits;
}		}

protected function buildBaseCommit($symbolic_commit) {		protected function buildBaseCommit($symbolic_commit) {
if ($symbolic_commit !== null) {		if ($symbolic_commit !== null) {
▲ Show 20 Lines • Show All 1,616 Lines • Show Last 20 Lines