Page MenuHomePhorge
Differential D25022 Diff 65 src/applications/phame/controller/post/PhamePostViewController.php

Changeset View

Standalone View

View Options

src/applications/phame/controller/post/PhamePostViewController.php

Show First 20 Lines • Show All 157 Lines • ▼ Show 20 Lines if ($next) {
$next_view->setNext($next->getTitle(), $next_view->setNext($next->getTitle(),
$next->getBestURI($is_live, $is_external)); $next->getBestURI($is_live, $is_external));
} }
if ($prev) { if ($prev) {
$next_view->setPrevious($prev->getTitle(), $next_view->setPrevious($prev->getTitle(),
$prev->getBestURI($is_live, $is_external)); $prev->getBestURI($is_live, $is_external));
} }
$monogram = $post->getMonogram();
$document->setFoot($next_view); $document->setFoot($next_view);
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$properties = phutil_tag_div('phui-document-view-pro-box', $properties); $properties = phutil_tag_div('phui-document-view-pro-box', $properties);
$title = pht('%s %s', $monogram, $post->getTitle());
valerio.bozzolanUnsubmitted
Not Done
Inline Actions
$properties = phutil_tag_div('phui-document-view-pro-box', $properties);
- $title = pht('%s %s', $monogram, $post->getTitle());
+ // When logged-in, add the J-ID in the page title, as Phorge does in other pages
+ // When logged-out, hide the J-ID from the title, since it might be confusing for
+ // inexperienced end users, interested in reading this post and nothing else.
+ // Also, the J-ID code is hidden since it could worsen the SEO.
+ if( $viewer->isLoggedIn() ) {
+ $title = pht('%s %s', $monogram, $post->getTitle());
+ } else {
+ $title = $post->getTitle();
+ }
$page = $this->newPage()

I have not tested this, but I like what @bekay suggested and this is probably the related natural change.

Please say if this still work for your need.

valerio.bozzolan: I have not tested this, but I like what @bekay suggested and this is probably the related…
$page = $this->newPage() $page = $this->newPage()
->setTitle($post->getTitle()) ->setTitle($title)
->setPageObjectPHIDs(array($post->getPHID())) ->setPageObjectPHIDs(array($post->getPHID()))
->setCrumbs($crumbs) ->setCrumbs($crumbs)
->appendChild( ->appendChild(
array( array(
$hero, $hero,
$document, $document,
$about, $about,
$properties, $properties,
▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0