Differential D25350 Diff 1144 src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Changeset View

Standalone View

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	);
}		}

public function runWorkflow() {		public function runWorkflow() {
$log = $this->getLogEngine();		$log = $this->getLogEngine();

$argv = $this->getArgument('argv');		$argv = $this->getArgument('argv');

$is_generate = $this->getArgument('generate');		$is_generate = $this->getArgument('generate');
$is_shell = (bool)strlen($this->getArgument('shell'));		$is_shell = phutil_nonempty_string($this->getArgument('shell'));
		valerio.bozzolanUnsubmitted Done Inline Actions Finally we can remove the `(bool)` valerio.bozzolan: Finally we can remove the `(bool)`
$is_current = $this->getArgument('current');		$is_current = $this->getArgument('current');

if ($argv) {		if ($argv) {
$should_install = false;		$should_install = false;
$should_generate = false;		$should_generate = false;

if ($is_generate) {		if ($is_generate) {
throw new PhutilArgumentUsageException(		throw new PhutilArgumentUsageException(
▲ Show 20 Lines • Show All 563 Lines • Show Last 20 Lines