Page MenuHomePhorge
Files F5488395

D25978.1750124259.diff
No OneTemporary
Actions

D25978.1750124259.diff
View Options

diff --git a/src/applications/config/controller/PhabricatorConfigController.php b/src/applications/config/controller/PhabricatorConfigController.php
--- a/src/applications/config/controller/PhabricatorConfigController.php
+++ b/src/applications/config/controller/PhabricatorConfigController.php
@@ -10,7 +10,7 @@
$viewer = $this->getViewer();
$file = PhabricatorFile::loadBuiltin($viewer, 'projects/v3/manage.png');
- $image = $file->getBestURI($file);
+ $image = $file->getBestURI();
$header = id(new PHUIHeaderView())
->setHeader($text)
->setProfileHeader(true)
diff --git a/src/applications/conpherence/controller/ConpherenceListController.php b/src/applications/conpherence/controller/ConpherenceListController.php
--- a/src/applications/conpherence/controller/ConpherenceListController.php
+++ b/src/applications/conpherence/controller/ConpherenceListController.php
@@ -133,8 +133,7 @@
->setObject($conpherence)
->execute();
$layout->setHeader($this->buildHeaderPaneContent(
- $conpherence,
- $policy_objects));
+ $conpherence));
$response = $this->newPage()
->setTitle($title)
->appendChild($layout);
diff --git a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
--- a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
+++ b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php
@@ -72,7 +72,7 @@
public function generateDescription() {
return id(new PhutilLipsumContextFreeGrammar())
- ->generate(10, 20);
+ ->generateSeveral(rand(10, 20), "\n");
}
public function generateTitle() {
diff --git a/src/applications/differential/storage/DifferentialChangeset.php b/src/applications/differential/storage/DifferentialChangeset.php
--- a/src/applications/differential/storage/DifferentialChangeset.php
+++ b/src/applications/differential/storage/DifferentialChangeset.php
@@ -587,7 +587,7 @@
$right_data);
$comparison = id(new self())
- ->makeEphemeral(true)
+ ->makeEphemeral()
->attachDiff($left->getDiff())
->setOldFile($left->getFilename())
->setFilename($file_name);
diff --git a/src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php b/src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php
--- a/src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php
+++ b/src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php
@@ -56,7 +56,7 @@
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
- return $this->newCurtainView($action_list)
+ return $this->newCurtainView()
->setActionList($action_list);
}
diff --git a/src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php b/src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php
--- a/src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php
+++ b/src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php
@@ -110,7 +110,6 @@
$status) {
$actor = $this->getActor();
- $acting_phid = $this->getActingAsPHID();
$audits = $commit->getAudits();
$audits = mpull($audits, null, 'getAuditorPHID');
@@ -120,7 +119,7 @@
$with_authority = ($status != PhabricatorAuditRequestStatus::RESIGNED);
if ($with_authority) {
foreach ($audits as $audit) {
- if ($commit->hasAuditAuthority($actor, $audit, $acting_phid)) {
+ if ($commit->hasAuditAuthority($actor, $audit)) {
$map[$audit->getAuditorPHID()] = $status;
}
}
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php b/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
--- a/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php
@@ -162,7 +162,7 @@
$viewer = $this->getViewer();
$this->openTransaction();
- $this->releaseArtifact($viewer);
+ $this->releaseArtifact();
$this->delete();
$this->saveTransaction();
}
diff --git a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
--- a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
@@ -454,7 +454,7 @@
}
private function getGitRefRules(PhabricatorRepository $repository) {
- $ref_rules = $repository->getFetchRules($repository);
+ $ref_rules = $repository->getFetchRules();
if (!$ref_rules) {
$ref_rules = array(
diff --git a/src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php b/src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php
--- a/src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php
+++ b/src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php
@@ -64,7 +64,7 @@
public function getDisplayName(
PhabricatorProfileMenuItemConfiguration $config) {
- $room = $this->getConpherence($config);
+ $room = $this->getConpherence();
if (!$room) {
return pht('(Restricted/Invalid Conpherence)');
}
@@ -101,7 +101,7 @@
protected function newMenuItemViewList(
PhabricatorProfileMenuItemConfiguration $config) {
$viewer = $this->getViewer();
- $room = $this->getConpherence($config);
+ $room = $this->getConpherence();
if (!$room) {
return array();
}
diff --git a/src/applications/search/query/PhabricatorSearchDocumentQuery.php b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
--- a/src/applications/search/query/PhabricatorSearchDocumentQuery.php
+++ b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
@@ -49,7 +49,7 @@
->setParameter('offset', $this->unfilteredOffset)
->setParameter('limit', $this->getRawResultLimit());
- $result_set = PhabricatorSearchService::newResultSet($query, $this);
+ $result_set = PhabricatorSearchService::newResultSet($query);
$phids = $result_set->getPHIDs();
$this->fulltextResultSet = $result_set;
diff --git a/src/infrastructure/editor/PhabricatorEditorURIEngine.php b/src/infrastructure/editor/PhabricatorEditorURIEngine.php
--- a/src/infrastructure/editor/PhabricatorEditorURIEngine.php
+++ b/src/infrastructure/editor/PhabricatorEditorURIEngine.php
@@ -68,7 +68,7 @@
}
public function getURIForPath($path, $line) {
- $tokens = $this->getURITokensForRepository($path);
+ $tokens = $this->getURITokensForRepository();
$variables = array(
'f' => $this->escapeToken($path),
@@ -81,7 +81,7 @@
}
public function getURITokensForPath($path) {
- $tokens = $this->getURITokensForRepository($path);
+ $tokens = $this->getURITokensForRepository();
$variables = array(
'f' => $this->escapeToken($path),

File Metadata

Mime Type
text/plain
Expires
Tue, Jun 17, 01:37 (16 h, 27 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1861872
Default Alt Text
D25978.1750124259.diff (7 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0