Page MenuHomePhorge
Files F2944025

D25122.1738237315.diff
No OneTemporary
Actions

D25122.1738237315.diff
View Options

diff --git a/scripts/repository/commit_hook.php b/scripts/repository/commit_hook.php
--- a/scripts/repository/commit_hook.php
+++ b/scripts/repository/commit_hook.php
@@ -119,12 +119,14 @@
exit($err);
} else if ($repository->isGit() || $repository->isHg()) {
$username = getenv(DiffusionCommitHookEngine::ENV_USER);
- if (!phutil_nonempty_string($username)) {
- throw new Exception(
- pht(
- 'No Direct Pushes: You are pushing directly to a hosted repository. '.
- 'This will not work. See "No Direct Pushes" in the documentation '.
- 'for more information.'));
+ if ($username !== false ) {
+ if (!phutil_nonempty_string($username)) {
+ throw new Exception(
+ pht(
+ 'No Direct Pushes: You are pushing directly to a hosted repository. '.
+ 'This will not work. See "No Direct Pushes" in the documentation '.
+ 'for more information.'));
+ }
}
if ($repository->isHg()) {
@@ -181,17 +183,17 @@
$engine->setOriginalArgv(array_slice($argv, 2));
$remote_address = getenv(DiffusionCommitHookEngine::ENV_REMOTE_ADDRESS);
-if (phutil_nonempty_string($remote_address)) {
+if ($remote_address !== false && phutil_nonempty_string($remote_address)) {
$engine->setRemoteAddress($remote_address);
}
$remote_protocol = getenv(DiffusionCommitHookEngine::ENV_REMOTE_PROTOCOL);
-if (phutil_nonempty_string($remote_protocol)) {
+if ($remote_protocol !== false && phutil_nonempty_string($remote_protocol)) {
$engine->setRemoteProtocol($remote_protocol);
}
$request_identifier = getenv(DiffusionCommitHookEngine::ENV_REQUEST);
-if (phutil_nonempty_string($request_identifier)) {
+if ($request_identifier !== false && phutil_nonempty_string($request_identifier)) {
$engine->setRequestIdentifier($request_identifier);
}

File Metadata

Mime Type
text/plain
Expires
Thu, Jan 30, 11:41 (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1153527
Default Alt Text
D25122.1738237315.diff (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0