Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2896993
D25585.1737244255.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
600 B
Referenced Files
None
Subscribers
None
D25585.1737244255.diff
View Options
diff --git a/src/applications/herald/management/HeraldRuleManagementWorkflow.php b/src/applications/herald/management/HeraldRuleManagementWorkflow.php
--- a/src/applications/herald/management/HeraldRuleManagementWorkflow.php
+++ b/src/applications/herald/management/HeraldRuleManagementWorkflow.php
@@ -33,7 +33,7 @@
$viewer = $this->getViewer();
$rule_name = $args->getArg('rule');
- if (!strlen($rule_name)) {
+ if (!phutil_nonempty_string($rule_name)) {
throw new PhutilArgumentUsageException(
pht('Specify a rule to edit with "--rule <id|monogram>".'));
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 18, 23:50 (1 h, 33 m ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1130082
Default Alt Text
D25585.1737244255.diff (600 B)
Attached To
Mode
D25585: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
Attached
Detach File
Event Timeline
Log In to Comment