Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2889917
D25408.1737204612.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25408.1737204612.diff
View Options
diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -328,7 +328,12 @@
->executeOne();
$non_update = false;
- $participant = $conpherence->getParticipant($user->getPHID());
+
+ // The User is always available. The Participant may not. See:
+ // User: it's you, lurking the Chat (maybe it's a public chat).
+ // Participant: it's you, if you are a Chat Member.
+ // https://we.phorge.it/T15497
+ $participant = $conpherence->getParticipantIfExists($user->getPHID());
if ($need_transactions && $conpherence->getTransactions()) {
$data = ConpherenceTransactionRenderer::renderTransactions(
@@ -336,7 +341,7 @@
$conpherence);
$key = PhabricatorConpherenceColumnMinimizeSetting::SETTINGKEY;
$minimized = $user->getUserSetting($key);
- if (!$minimized) {
+ if (!$minimized && $participant) {
$participant->markUpToDate($conpherence);
}
} else if ($need_transactions) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 18, 12:50 (20 h, 12 m ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1111643
Default Alt Text
D25408.1737204612.diff (1 KB)
Attached To
Mode
D25408: Fix Exception in Chat room when you are not a Participant
Attached
Detach File
Event Timeline
Log In to Comment