Page MenuHomePhorge
Files F2888708

D25084.1737191886.diff
No OneTemporary
Actions

D25084.1737191886.diff
View Options

diff --git a/src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php b/src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php
--- a/src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php
+++ b/src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php
@@ -79,14 +79,12 @@
$same_window = $engine->getConfig('uri.same-window', null);
if ($same_window === null) {
- // TODO:
// Instead of assuming every link as external,
// assume that only external links should be opened
// externally. This still probably creates lot of
// external links than needed, but less than before.
// https://we.phorge.it/T15161
-// $same_window = $this->isInternalGenericURI($link);
- $same_window = false;
+ $same_window = $this->isInternalGenericURI($link);
}
if ($same_window) {
diff --git a/src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php b/src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php
--- a/src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php
+++ b/src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php
@@ -119,14 +119,12 @@
$same_window = $engine->getConfig('uri.same-window', null);
if ($same_window === null) {
- // TODO:
// Instead of assuming every link as external,
// assume that only external links should be opened
// externally. This still probably creates lot of
// external links than needed, but less than before.
// https://we.phorge.it/T15161
-// $same_window = $this->isInternalAbsoluteURI($link);
- $same_window = false;
+ $same_window = $this->isInternalAbsoluteURI($link);
}
if ($same_window) {

File Metadata

Mime Type
text/plain
Expires
Sat, Jan 18, 09:18 (10 h, 28 m ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1124054
Default Alt Text
D25084.1737191886.diff (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0