Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2871177
D25638.1736838846.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
833 B
Referenced Files
None
Subscribers
None
D25638.1736838846.diff
View Options
diff --git a/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php b/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php
--- a/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php
+++ b/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php
@@ -208,12 +208,12 @@
$this->activeEngine = $engine;
$encode_setting = $request->getStr('encode');
- if (strlen($encode_setting)) {
+ if (phutil_nonempty_string($encode_setting)) {
$engine->setEncodingConfiguration($encode_setting);
}
$highlight_setting = $request->getStr('highlight');
- if (strlen($highlight_setting)) {
+ if (phutil_nonempty_string($highlight_setting)) {
$engine->setHighlightingConfiguration($highlight_setting);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Jan 14, 07:14 (4 d, 20 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1113957
Default Alt Text
D25638.1736838846.diff (833 B)
Attached To
Mode
D25638: Fix PHP 8.1 "strlen(null)" exception rendering files/documents
Attached
Detach File
Event Timeline
Log In to Comment