Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2869421
D25800.1736704545.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
535 B
Referenced Files
None
Subscribers
None
D25800.1736704545.diff
View Options
diff --git a/src/parser/xhpast/__tests__/PHPASTParserTestCase.php b/src/parser/xhpast/__tests__/PHPASTParserTestCase.php
--- a/src/parser/xhpast/__tests__/PHPASTParserTestCase.php
+++ b/src/parser/xhpast/__tests__/PHPASTParserTestCase.php
@@ -82,7 +82,7 @@
case 'pass':
$this->assertEqual(0, $err, pht('Exit code for "%s".', $name));
- if (!strlen($expect)) {
+ if (!phutil_nonempty_string($expect)) {
// If there's no "expect" data in the test case, that's OK.
break;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Jan 12, 17:55 (5 d, 18 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1112788
Default Alt Text
D25800.1736704545.diff (535 B)
Attached To
Mode
D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
Attached
Detach File
Event Timeline
Log In to Comment