Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2693836
D25150.1734770464.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
956 B
Referenced Files
None
Subscribers
None
D25150.1734770464.diff
View Options
diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -97,19 +97,19 @@
AphrontRequest $request) {
$short_name = $request->getURIData('repositoryShortName');
- if (strlen($short_name)) {
+ if (phutil_nonempty_string($short_name)) {
// If the short name ends in ".git", ignore it.
$short_name = preg_replace('/\\.git\z/', '', $short_name);
return $short_name;
}
$identifier = $request->getURIData('repositoryCallsign');
- if (strlen($identifier)) {
+ if (phutil_nonempty_string($identifier)) {
return $identifier;
}
$id = $request->getURIData('repositoryID');
- if (strlen($id)) {
+ if (phutil_nonempty_string($id)) {
return (int)$id;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 08:41 (16 h, 23 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1021302
Default Alt Text
D25150.1734770464.diff (956 B)
Attached To
Mode
D25150: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page
Attached
Detach File
Event Timeline
Log In to Comment