Page MenuHomePhorge

D25287.1734769704.diff
No OneTemporary

D25287.1734769704.diff

diff --git a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
@@ -47,14 +47,14 @@
$against_hash = $request->getValue('against');
$path = $request->getValue('path');
- if (!strlen($path)) {
+ if (!phutil_nonempty_string($path)) {
$path = null;
}
$offset = $request->getValue('offset');
$limit = $request->getValue('limit');
- if (strlen($against_hash)) {
+ if (phutil_nonempty_string($against_hash)) {
$commit_range = "{$against_hash}..{$commit_hash}";
} else {
$commit_range = $commit_hash;

File Metadata

Mime Type
text/plain
Expires
Sat, Dec 21, 08:28 (1 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016597
Default Alt Text
D25287.1734769704.diff (834 B)

Event Timeline