Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2693748
D25287.1734769704.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
834 B
Referenced Files
None
Subscribers
None
D25287.1734769704.diff
View Options
diff --git a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
@@ -47,14 +47,14 @@
$against_hash = $request->getValue('against');
$path = $request->getValue('path');
- if (!strlen($path)) {
+ if (!phutil_nonempty_string($path)) {
$path = null;
}
$offset = $request->getValue('offset');
$limit = $request->getValue('limit');
- if (strlen($against_hash)) {
+ if (phutil_nonempty_string($against_hash)) {
$commit_range = "{$against_hash}..{$commit_hash}";
} else {
$commit_range = $commit_hash;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 08:28 (1 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016597
Default Alt Text
D25287.1734769704.diff (834 B)
Attached To
Mode
D25287: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history
Attached
Detach File
Event Timeline
Log In to Comment