Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2689357
D25345.1734733086.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
964 B
Referenced Files
None
Subscribers
None
D25345.1734733086.diff
View Options
diff --git a/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php b/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
--- a/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
+++ b/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
@@ -42,7 +42,7 @@
}
$column_key = $request->getStr('columnKey');
- if (strlen($column_key)) {
+ if (phutil_nonempty_string($column_key)) {
$columns = $ref_list->getColumns();
if (!isset($columns[$column_key])) {
return new Aphront404Response();
@@ -52,7 +52,7 @@
$after_ref = null;
$after_key = $request->getStr('afterKey');
- if (strlen($after_key)) {
+ if (phutil_nonempty_string($after_key)) {
$after_ref = $ref_list->getPanelRef($after_key);
if (!$after_ref) {
return new Aphront404Response();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 22:18 (11 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1021189
Default Alt Text
D25345.1734733086.diff (964 B)
Attached To
Mode
D25345: Fix /dashboard/adjust/remove/ PHP 8.1 strlen(null) errors
Attached
Detach File
Event Timeline
Log In to Comment