Page MenuHomePhorge
Files F2686649

D25634.1734719435.diff
No OneTemporary
Actions

D25634.1734719435.diff
View Options

diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -627,25 +627,4 @@
return $this->delegateToController($controller);
}
-
-/* -( Deprecated )--------------------------------------------------------- */
-
-
- /**
- * DEPRECATED. Use @{method:newPage}.
- */
- public function buildStandardPageView() {
- return $this->newPage();
- }
-
-
- /**
- * DEPRECATED. Use @{method:newPage}.
- */
- public function buildStandardPageResponse($view, array $data) {
- $page = $this->buildStandardPageView();
- $page->appendChild($view);
- return $page->produceAphrontResponse();
- }
-
}
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewController.php
@@ -1,18 +1,4 @@
<?php
abstract class PhabricatorXHPASTViewController extends PhabricatorController {
-
- public function buildStandardPageResponse($view, array $data) {
- $page = $this->buildStandardPageView();
-
- $page->setApplicationName('XHPASTView');
- $page->setBaseURI('/xhpast/');
- $page->setTitle(idx($data, 'title'));
- $page->setGlyph("\xE2\x96\xA0");
- $page->appendChild($view);
-
- $response = new AphrontWebpageResponse();
- return $response->setContent($page->render());
- }
-
}
diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
--- a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
+++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php
@@ -10,17 +10,18 @@
public function handleRequest(AphrontRequest $request) {
$id = $request->getURIData('id');
- return $this->buildStandardPageResponse(
- phutil_tag(
+ return $this->newPage()
+ ->setApplicationName('XHPASTView')
+ ->setBaseURI('/xhpast/')
+ ->setTitle(pht('XHPAST View'))
+ ->setGlyph("\xE2\x96\xA0")
+ ->appendChild(phutil_tag(
'iframe',
array(
'src' => "/xhpast/frameset/{$id}/",
'frameborder' => '0',
'style' => 'width: 100%; height: 800px;',
'',
- )),
- array(
- 'title' => pht('XHPAST View'),
- ));
+ )));
}
}

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 18:30 (16 h, 30 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1019046
Default Alt Text
D25634.1734719435.diff (2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0