Page MenuHomePhorge
Files F2683985

D25096.1734695144.diff
No OneTemporary
Actions

D25096.1734695144.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => '0e3cf785',
'conpherence.pkg.js' => '020aebcf',
- 'core.pkg.css' => 'bb377509',
+ 'core.pkg.css' => '6590cb9f',
'core.pkg.js' => '66c49ca1',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '609e63d4',
@@ -178,7 +178,7 @@
'rsrc/css/phui/phui-spacing.css' => 'b05cadc3',
'rsrc/css/phui/phui-status.css' => '293b5dad',
'rsrc/css/phui/phui-tag-view.css' => 'fb811341',
- 'rsrc/css/phui/phui-timeline-view.css' => '2d32d7a9',
+ 'rsrc/css/phui/phui-timeline-view.css' => 'cc554a79',
'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f',
'rsrc/css/phui/workboards/phui-workboard-color.css' => '3a1c21ff',
'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98',
@@ -880,7 +880,7 @@
'phui-status-list-view-css' => '293b5dad',
'phui-tag-view-css' => 'fb811341',
'phui-theme-css' => '35883b37',
- 'phui-timeline-view-css' => '2d32d7a9',
+ 'phui-timeline-view-css' => 'cc554a79',
'phui-two-column-view-css' => 'f96d319f',
'phui-workboard-color-css' => '3a1c21ff',
'phui-workboard-view-css' => '74fc9d98',
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -539,7 +539,7 @@
case PhabricatorTransactions::TYPE_COMMENT;
$comment = $this->getComment();
if ($comment && $comment->getIsRemoved()) {
- return 'black';
+ return 'grey';
}
break;
case PhabricatorTransactions::TYPE_EDGE:
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -493,6 +493,11 @@
$xaction->getComment() &&
$xaction->getComment()->getIsRemoved();
+ // Make designers happy to make CSS customizations
+ if ($has_removed_comment) {
+ $event->addClass('phui-timeline-shell-removed');
+ }
+
if ($xaction->getCommentVersion() > 1 && !$has_removed_comment) {
$event->setIsEdited(true);
}
diff --git a/webroot/rsrc/css/phui/phui-timeline-view.css b/webroot/rsrc/css/phui/phui-timeline-view.css
--- a/webroot/rsrc/css/phui/phui-timeline-view.css
+++ b/webroot/rsrc/css/phui/phui-timeline-view.css
@@ -189,9 +189,29 @@
overflow-x: auto;
}
+/*
+ * Start Customization for removed comments
+ * https://we.phorge.it/T15192
+ */
+
.phui-timeline-core-content .comment-deleted {
font-style: italic;
}
+.phui-timeline-shell-removed .phui-timeline-image {
+ opacity: 0.5;
+}
+.phui-timeline-shell-removed,
+.phui-timeline-shell-removed a,
+.phui-timeline-shell-removed .phui-timeline-title {
+ color:#888; /* grey */
+}
+.phui-timeline-shell-removed
+ .phui-timeline-major-event
+ .phui-timeline-content .phui-timeline-core-content {
+ padding:4px 16px; /* reduce vertical space from 16px */
+}
+
+/* End Customization for removed comments */
.device .phui-timeline-event-view {
min-height: 23px;

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 11:45 (20 h, 39 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1017457
Default Alt Text
D25096.1734695144.diff (3 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0