Page MenuHomePhorge
Files F2682472

D25831.1734660738.diff
No OneTemporary
Actions

D25831.1734660738.diff
View Options

diff --git a/src/future/FutureProxy.php b/src/future/FutureProxy.php
--- a/src/future/FutureProxy.php
+++ b/src/future/FutureProxy.php
@@ -8,7 +8,7 @@
private $proxied;
- public function __construct(Future $proxied = null) {
+ public function __construct(?Future $proxied = null) {
if ($proxied) {
$this->setProxiedFuture($proxied);
}
diff --git a/src/parser/aast/api/AASTNode.php b/src/parser/aast/api/AASTNode.php
--- a/src/parser/aast/api/AASTNode.php
+++ b/src/parser/aast/api/AASTNode.php
@@ -42,7 +42,7 @@
return $this->parentNode;
}
- final public function setParentNode(AASTNode $node = null) {
+ final public function setParentNode(?AASTNode $node = null) {
$this->parentNode = $node;
return $this;
}
@@ -51,7 +51,7 @@
return $this->previousSibling;
}
- final public function setPreviousSibling(AASTNode $node = null) {
+ final public function setPreviousSibling(?AASTNode $node = null) {
$this->previousSibling = $node;
return $this;
}
@@ -60,7 +60,7 @@
return $this->nextSibling;
}
- final public function setNextSibling(AASTNode $node = null) {
+ final public function setNextSibling(?AASTNode $node = null) {
$this->nextSibling = $node;
return $this;
}
diff --git a/src/repository/marker/ArcanistMarkerRef.php b/src/repository/marker/ArcanistMarkerRef.php
--- a/src/repository/marker/ArcanistMarkerRef.php
+++ b/src/repository/marker/ArcanistMarkerRef.php
@@ -174,7 +174,7 @@
return $this->getHardpoint(self::HARDPOINT_WORKINGCOPYSTATEREF);
}
- public function attachRemoteRef(ArcanistRemoteRef $ref = null) {
+ public function attachRemoteRef(?ArcanistRemoteRef $ref = null) {
return $this->attachHardpoint(self::HARDPOINT_REMOTEREF, $ref);
}
diff --git a/src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php b/src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php
--- a/src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php
+++ b/src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php
@@ -7,11 +7,11 @@
return $this->newMarkers();
}
- protected function newRemoteRefMarkers(ArcanistRemoteRef $remote = null) {
+ protected function newRemoteRefMarkers(?ArcanistRemoteRef $remote = null) {
return $this->newMarkers($remote);
}
- private function newMarkers(ArcanistRemoteRef $remote = null) {
+ private function newMarkers(?ArcanistRemoteRef $remote = null) {
$api = $this->getRepositoryAPI();
// In native Mercurial it is difficult to identify remote markers, and
diff --git a/src/unit/ArcanistUnitTestResult.php b/src/unit/ArcanistUnitTestResult.php
--- a/src/unit/ArcanistUnitTestResult.php
+++ b/src/unit/ArcanistUnitTestResult.php
@@ -111,7 +111,7 @@
* "extra data" allows an implementation to store additional key/value
* metadata along with the result of the test run.
*/
- public function setExtraData(array $extra_data = null) {
+ public function setExtraData(?array $extra_data = null) {
$this->extraData = $extra_data;
return $this;
}
diff --git a/src/unit/engine/ArcanistUnitTestEngine.php b/src/unit/engine/ArcanistUnitTestEngine.php
--- a/src/unit/engine/ArcanistUnitTestEngine.php
+++ b/src/unit/engine/ArcanistUnitTestEngine.php
@@ -78,7 +78,7 @@
return $this->enableCoverage;
}
- final public function setRenderer(ArcanistUnitRenderer $renderer = null) {
+ final public function setRenderer(?ArcanistUnitRenderer $renderer = null) {
$this->renderer = $renderer;
return $this;
}

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 02:12 (15 h, 14 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016376
Default Alt Text
D25831.1734660738.diff (3 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0