Page MenuHomePhorge
Files F2664917

D25802.1733424718.diff
No OneTemporary
Actions

D25802.1733424718.diff
View Options

diff --git a/src/applications/auth/factor/PhabricatorDuoAuthFactor.php b/src/applications/auth/factor/PhabricatorDuoAuthFactor.php
--- a/src/applications/auth/factor/PhabricatorDuoAuthFactor.php
+++ b/src/applications/auth/factor/PhabricatorDuoAuthFactor.php
@@ -650,7 +650,6 @@
'You denied this request. Wait %s second(s) to try again.',
new PhutilNumber($wait_duration)));
}
- break;
}
return null;
diff --git a/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php b/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
--- a/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
+++ b/src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
@@ -79,7 +79,6 @@
'%s disabled this provider.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_LOGIN:
if ($new) {
return pht(
@@ -90,7 +89,6 @@
'%s disabled login.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_REGISTRATION:
if ($new) {
return pht(
@@ -101,7 +99,6 @@
'%s disabled registration.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_LINK:
if ($new) {
return pht(
@@ -112,7 +109,6 @@
'%s disabled account linking.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_UNLINK:
if ($new) {
return pht(
@@ -123,7 +119,6 @@
'%s disabled account unlinking.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_TRUST_EMAILS:
if ($new) {
return pht(
@@ -134,7 +129,6 @@
'%s disabled email trust.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_AUTO_LOGIN:
if ($new) {
return pht(
@@ -145,7 +139,6 @@
'%s disabled auto login.',
$this->renderHandleLink($author_phid));
}
- break;
case self::TYPE_PROPERTY:
$provider = $this->getProvider();
if ($provider) {
@@ -158,7 +151,6 @@
return pht(
'%s edited a property of this provider.',
$this->renderHandleLink($author_phid));
- break;
}
return parent::getTitle();
diff --git a/src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php b/src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php
--- a/src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php
+++ b/src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php
@@ -575,7 +575,6 @@
pht(
'RRULE specifies BYMONTHDAY with FREQ set to WEEKLY, which '.
'violates RFC5545.'));
- break;
default:
break;
}
diff --git a/src/applications/config/storage/PhabricatorConfigTransaction.php b/src/applications/config/storage/PhabricatorConfigTransaction.php
--- a/src/applications/config/storage/PhabricatorConfigTransaction.php
+++ b/src/applications/config/storage/PhabricatorConfigTransaction.php
@@ -45,7 +45,6 @@
'%s edited this configuration entry.',
$this->renderHandleLink($author_phid));
}
- break;
}
return parent::getTitle();
@@ -83,7 +82,6 @@
$this->renderHandleLink($author_phid),
$this->getObject()->getConfigKey());
}
- break;
}
return parent::getTitle();
@@ -145,7 +143,6 @@
} else {
return PhabricatorTransactions::COLOR_BLUE;
}
- break;
}
}
diff --git a/src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php b/src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php
--- a/src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php
+++ b/src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php
@@ -62,7 +62,6 @@
switch ($error_code) {
case ConpherenceEditor::ERROR_EMPTY_PARTICIPANTS:
throw new ConduitException('ERR_EMPTY_PARTICIPANT_PHIDS');
- break;
}
}
}
diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php
--- a/src/applications/conpherence/controller/ConpherenceUpdateController.php
+++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php
@@ -139,7 +139,6 @@
break;
default:
throw new Exception(pht('Unknown action: %s', $action));
- break;
}
if ($xactions) {
@@ -173,19 +172,16 @@
$latest_transaction_id);
return id(new AphrontAjaxResponse())
->setContent($content);
- break;
case 'go-home':
$content = array(
'href' => $this->getApplicationURI(),
);
return id(new AphrontAjaxResponse())
->setContent($content);
- break;
case 'redirect':
default:
return id(new AphrontRedirectResponse())
->setURI('/'.$conpherence->getMonogram());
- break;
}
}
}
diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php
--- a/src/applications/conpherence/storage/ConpherenceThread.php
+++ b/src/applications/conpherence/storage/ConpherenceThread.php
@@ -271,7 +271,6 @@
switch ($capability) {
case PhabricatorPolicyCapability::CAN_VIEW:
return pht('Participants in a room can always view it.');
- break;
}
}
diff --git a/src/applications/conpherence/view/ConpherenceTransactionView.php b/src/applications/conpherence/view/ConpherenceTransactionView.php
--- a/src/applications/conpherence/view/ConpherenceTransactionView.php
+++ b/src/applications/conpherence/view/ConpherenceTransactionView.php
@@ -88,7 +88,6 @@
$viewer,
'M jS, Y')),
));
- break;
}
$info = $this->renderTransactionInfo();
diff --git a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
--- a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
@@ -81,7 +81,6 @@
pht(
'Unsupported action "%s".',
$action));
- break;
}
}
diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -252,11 +252,9 @@
$commit_name,
$author_name);
}
- break;
default:
return DifferentialAction::getBasicStoryText($new, $author_handle);
}
- break;
}
return parent::getTitle();
@@ -366,7 +364,6 @@
$commit_name);
}
}
- break;
case DifferentialAction::ACTION_REQUEST:
return pht(
diff --git a/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php
@@ -162,7 +162,6 @@
break;
default:
throw new ConduitException('ERR-UNKNOWN-VCS-TYPE');
- break;
}
return $result;
}
diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
--- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
+++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
@@ -1371,7 +1371,6 @@
return id(new DiffusionCommitRef())
->setMessage($message);
- break;
default:
throw new Exception(pht("Unknown VCS '%s!'", $vcs));
}
diff --git a/src/applications/feed/story/PhabricatorFeedStory.php b/src/applications/feed/story/PhabricatorFeedStory.php
--- a/src/applications/feed/story/PhabricatorFeedStory.php
+++ b/src/applications/feed/story/PhabricatorFeedStory.php
@@ -223,7 +223,6 @@
break;
default:
throw new Exception(pht('Unknown rendering target: %s', $target));
- break;
}
}
diff --git a/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php b/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
--- a/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
+++ b/src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php
@@ -139,6 +139,5 @@
return 0;
}
- return 0;
}
}
diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
--- a/src/applications/files/storage/PhabricatorFile.php
+++ b/src/applications/files/storage/PhabricatorFile.php
@@ -1038,13 +1038,10 @@
case 'jpg';
case 'jpeg':
return function_exists('imagejpeg');
- break;
case 'png':
return function_exists('imagepng');
- break;
case 'gif':
return function_exists('imagegif');
- break;
default:
throw new Exception(pht('Unknown type matched as image MIME type.'));
}
diff --git a/src/applications/flag/query/PhabricatorFlagQuery.php b/src/applications/flag/query/PhabricatorFlagQuery.php
--- a/src/applications/flag/query/PhabricatorFlagQuery.php
+++ b/src/applications/flag/query/PhabricatorFlagQuery.php
@@ -123,7 +123,6 @@
default:
throw new Exception(
pht('Unknown groupBy parameter: %s', $this->groupBy));
- break;
}
return $flags;
diff --git a/src/applications/herald/field/HeraldField.php b/src/applications/herald/field/HeraldField.php
--- a/src/applications/herald/field/HeraldField.php
+++ b/src/applications/herald/field/HeraldField.php
@@ -144,7 +144,6 @@
return $tokenizer;
}
- break;
}
diff --git a/src/applications/legalpad/storage/LegalpadDocumentBody.php b/src/applications/legalpad/storage/LegalpadDocumentBody.php
--- a/src/applications/legalpad/storage/LegalpadDocumentBody.php
+++ b/src/applications/legalpad/storage/LegalpadDocumentBody.php
@@ -54,7 +54,6 @@
break;
default:
throw new Exception(pht('Unknown field: %s', $field));
- break;
}
return $text;
diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -130,7 +130,6 @@
$this->renderHandleLink($author_phid),
$this->renderSubtypeName($old),
$this->renderSubtypeName($new));
- break;
}
return parent::getTitle();
diff --git a/src/applications/nuance/github/NuanceGitHubRawEvent.php b/src/applications/nuance/github/NuanceGitHubRawEvent.php
--- a/src/applications/nuance/github/NuanceGitHubRawEvent.php
+++ b/src/applications/nuance/github/NuanceGitHubRawEvent.php
@@ -266,7 +266,6 @@
default:
return pht('Ref %s', $ref);
}
- break;
case 'PushEvent':
$ref = idxv($raw, array('payload', 'ref'));
if (preg_match('(^refs/heads/)', $ref)) {
@@ -274,7 +273,6 @@
} else {
return pht('Ref %s', $ref);
}
- break;
case 'WatchEvent':
$actor = idxv($raw, array('actor', 'login'));
return pht('User %s', $actor);
@@ -362,7 +360,6 @@
default:
return pht('"%s"', $action);
}
- break;
case 'IssueCommentEvent':
$action = idxv($raw, array('payload', 'action'));
switch ($action) {
@@ -371,7 +368,6 @@
default:
return pht('"%s"', $action);
}
- break;
case 'PullRequestEvent':
$action = idxv($raw, array('payload', 'action'));
switch ($action) {
@@ -380,7 +376,6 @@
default:
return pht('"%s"', $action);
}
- break;
case 'WatchEvent':
return pht('Watched');
}
diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php
--- a/src/applications/phame/storage/PhamePost.php
+++ b/src/applications/phame/storage/PhamePost.php
@@ -222,7 +222,6 @@
} else {
return PhabricatorPolicies::POLICY_NOONE;
}
- break;
case PhabricatorPolicyCapability::CAN_EDIT:
if ($this->getBlog()) {
return $this->getBlog()->getEditPolicy();
diff --git a/src/applications/phrequent/storage/PhrequentTimeBlock.php b/src/applications/phrequent/storage/PhrequentTimeBlock.php
--- a/src/applications/phrequent/storage/PhrequentTimeBlock.php
+++ b/src/applications/phrequent/storage/PhrequentTimeBlock.php
@@ -318,7 +318,6 @@
}
}
- return 0;
}
}
diff --git a/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php b/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php
--- a/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php
+++ b/src/applications/settings/setting/PhabricatorConpherenceSoundSetting.php
@@ -50,7 +50,6 @@
ConpherenceRoomSettings::SOUND_MENTION =>
ConpherenceRoomSettings::DEFAULT_MENTION_SOUND,
);
- break;
case self::VALUE_CONPHERENCE_MENTION:
return array(
ConpherenceRoomSettings::SOUND_RECEIVE =>
@@ -58,7 +57,6 @@
ConpherenceRoomSettings::SOUND_MENTION =>
ConpherenceRoomSettings::DEFAULT_MENTION_SOUND,
);
- break;
case self::VALUE_CONPHERENCE_SILENT:
return array(
ConpherenceRoomSettings::SOUND_RECEIVE =>
@@ -66,7 +64,6 @@
ConpherenceRoomSettings::SOUND_MENTION =>
ConpherenceRoomSettings::DEFAULT_NO_SOUND,
);
- break;
}
}
diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php
--- a/src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php
+++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php
@@ -37,7 +37,6 @@
break;
default:
return new Aphront404Response();
- break;
}
if ($type == 'old') {
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -678,7 +678,6 @@
} else {
return false;
}
- break;
case PhabricatorTransactions::TYPE_CUSTOMFIELD:
$field = $this->getTransactionCustomField();
if ($field) {
@@ -705,7 +704,6 @@
return true;
}
return false;
- break;
default:
break;
}
@@ -1061,7 +1059,6 @@
'%s updated subscribers...',
$this->renderHandleLink($author_phid));
}
- break;
case PhabricatorTransactions::TYPE_FILE:
$add = array_diff_key($new, $old);
$add = array_keys($add);
@@ -1179,7 +1176,6 @@
$this->renderHandleLink($author_phid));
}
- break;
case PhabricatorTransactions::TYPE_EDGE:
$record = PhabricatorEdgeChangeRecord::newFromTransaction($this);
$add = $record->getAddedPHIDs();
@@ -1275,7 +1271,6 @@
$this->renderHandleLink($author_phid),
new PhutilNumber($undone));
}
- break;
case PhabricatorTransactions::TYPE_COLUMNS:
$moves = $this->getInterestingMoves($new);
@@ -1315,8 +1310,6 @@
phutil_count($moves),
phutil_implode_html(', ', $fragments));
}
- break;
-
case PhabricatorTransactions::TYPE_MFA:
return pht(
@@ -1490,7 +1483,6 @@
phutil_count($moves),
phutil_implode_html(', ', $fragments));
}
- break;
case PhabricatorTransactions::TYPE_MFA:
return null;
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -376,7 +376,6 @@
break;
default:
throw new Exception(pht('Incorrect Property Passed'));
- break;
}
}

File Metadata

Mime Type
text/plain
Expires
Thu, Dec 5, 18:51 (16 h, 24 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1003028
Default Alt Text
D25802.1733424718.diff (17 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0