D25449.1732015669.diff
No OneTemporary
Actions

Size

635 B

Referenced Files

None

Subscribers

None

D25449.1732015669.diff
View Options

	diff --git a/src/applications/auth/engine/PhabricatorAuthCSRFEngine.php b/src/applications/auth/engine/PhabricatorAuthCSRFEngine.php
	--- a/src/applications/auth/engine/PhabricatorAuthCSRFEngine.php
	+++ b/src/applications/auth/engine/PhabricatorAuthCSRFEngine.php
	@@ -47,7 +47,10 @@
	// We expect a BREACH-mitigating token. See T3684.
	$breach_prefix = $this->getBREACHPrefix();
	$breach_prelen = strlen($breach_prefix);
	- if (strncmp($token, $breach_prefix, $breach_prelen) !== 0) {
	+ if (
	+ $token === null \|\|
	+ strncmp($token, $breach_prefix, $breach_prelen) !== 0
	+ ) {
	return false;
	}