I created this Task as "Resolved" and it will be probably created with the following feed, in this order:
- valerio.bozzolan closed this task as Resolved.Wed, May 8, 10:13 AM
- valerio.bozzolan triaged this task as High priority.
- valerio.bozzolan __created this task__.
Here, reproduced:
{F2182823,size=full}
Instead, this is the expected feed order:
- valerio.bozzolan __created this task__.
- valerio.bozzolan closed this task as Resolved.Wed, May 8, 10:13 AM
- valerio.bozzolan triaged this task as High priority.
## Troubleshooting
It seems the "created this task" phrase comes from the `ManiphestTransactionEditor` method `getCreateObjectTitle()`:
https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/editor/ManiphestTransactionEditor.php;af300016b678fd0694a4ecde00de167677acff80$30
That seems in use by `PhabricatorCoreCreateTransaction` method `getTitle()`:
https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php;af300016b678fd0694a4ecde00de167677acff80$18
Note that the above class inherits this default `getActionStrength()` returning null:
https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorModularTransactionType.php;af300016b678fd0694a4ecde00de167677acff80$78-80
---
Also some probably relevant code:
- `ManiphestTaskTitleTransaction` (that seems not in use here for this specific bug report):
- https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php;af300016b678fd0694a4ecde00de167677acff80$17
- See the `getActionStrength()` = `140`.
- `ManiphestTaskStatusTransaction`
- https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php;af300016b678fd0694a4ecde00de167677acff80$25
- See the `getActionStrength()` = `130`.
- `ManiphestTaskStatusTransaction`
- https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php;af300016b678fd0694a4ecde00de167677acff80$25
- See the `getActionStrength()` = `130`.
## Proposal n. 1
So, probably, `PhabricatorCoreCreateTransaction` should have a `getActionStrength()` of 140.
Just like `ManiphestTaskTitleTransaction` or similar ones.
Example:
```
diff --git a/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php b/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php
index 0c8c337193..03255afbc6 100644
--- a/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php
+++ b/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php
@@ -27,4 +27,8 @@ final class PhabricatorCoreCreateTransaction
return $editor->getCreateObjectTitleForFeed($author, $object);
}
+ public function getActionStrength() {
+ return 140;
+ }
+
}
```
✅ This approach was tested and seems to work.
It improves the situation in: Maniphest, Phriction.
It has no negative impact on these that seem already OK: Calendar, Dashboard, Dashboard Panel, Diffusion, Macro, Paste, Ponder, Project, Pholio.
It has no positive impact on these that seem still in the wrong order: Differential.
## Proposal n. 2
...