Differential D25240 Diff 853 src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
Changeset View
Changeset View
Standalone View
Standalone View
src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
Show First 20 Lines • Show All 383 Lines • ▼ Show 20 Lines | public function validateApplicationTransactions( | ||||||||||||
return $errors; | return $errors; | ||||||||||||
} | } | ||||||||||||
protected function isValueEmpty($value) { | protected function isValueEmpty($value) { | ||||||||||||
if (is_array($value)) { | if (is_array($value)) { | ||||||||||||
return empty($value); | return empty($value); | ||||||||||||
} | } | ||||||||||||
return !strlen($value); | $is_empty = phutil_string_cast($value) === ''; | ||||||||||||
return $is_empty; | |||||||||||||
valerio.bozzolan: Proposed change:
```lang=php
$is_empty = phutil_string_cast($value) === '';
return $is_empty… | |||||||||||||
speckUnsubmitted Not Done Inline Actions
Instead of casting to string please do a null check speck: Instead of casting to string please do a null check | |||||||||||||
} | } | ||||||||||||
public function getApplicationTransactionTitle( | public function getApplicationTransactionTitle( | ||||||||||||
PhabricatorApplicationTransaction $xaction) { | PhabricatorApplicationTransaction $xaction) { | ||||||||||||
$author_phid = $xaction->getAuthorPHID(); | $author_phid = $xaction->getAuthorPHID(); | ||||||||||||
$old = $xaction->getOldValue(); | $old = $xaction->getOldValue(); | ||||||||||||
$new = $xaction->getNewValue(); | $new = $xaction->getNewValue(); | ||||||||||||
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines |
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
Proposed change: