Differential D25238 Diff 794 src/applications/conduit/controller/PhabricatorConduitAPIController.php

Changeset View

Standalone View

Show All 31 Lines	try {
$call = new ConduitCall($method, $params, $strictly_typed);		$call = new ConduitCall($method, $params, $strictly_typed);
$method_implementation = $call->getMethodImplementation();		$method_implementation = $call->getMethodImplementation();

$result = null;		$result = null;

// TODO: The relationship between ConduitAPIRequest and ConduitCall is a		// TODO: The relationship between ConduitAPIRequest and ConduitCall is a
// little odd here and could probably be improved. Specifically, the		// little odd here and could probably be improved. Specifically, the
// APIRequest is a sub-object of the Call, which does not parallel the		// APIRequest is a sub-object of the Call, which does not parallel the
// role of AphrontRequest (which is an indepenent object).		// role of AphrontRequest (which is an independent object).
// In particular, the setUser() and getUser() existing independently on		// In particular, the setUser() and getUser() existing independently on
// the Call and APIRequest is very awkward.		// the Call and APIRequest is very awkward.

$api_request = $call->getAPIRequest();		$api_request = $call->getAPIRequest();

$allow_unguarded_writes = false;		$allow_unguarded_writes = false;
$auth_error = null;		$auth_error = null;
$conduit_username = '-';		$conduit_username = '-';
▲ Show 20 Lines • Show All 707 Lines • Show Last 20 Lines