Page MenuHomePhorge
Differential D25202 Diff 696 src/applications/transactions/storage/PhabricatorModularTransactionType.php

Changeset View

Standalone View

View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines final protected function isNewObject() {
return $this->getEditor()->getIsNewObject(); return $this->getEditor()->getIsNewObject();
} }
final protected function isEmptyTextTransaction($value, array $xactions) { final protected function isEmptyTextTransaction($value, array $xactions) {
foreach ($xactions as $xaction) { foreach ($xactions as $xaction) {
$value = $xaction->getNewValue(); $value = $xaction->getNewValue();
} }
return !strlen($value); return !phutil_nonempty_string($value);
valerio.bozzolanUnsubmitted
Not Done
Inline Actions
$value = $xaction->getNewValue();
}
- return !phutil_nonempty_string($value);
+ $value_str = phutil_string_cast($value);
+ return $value_str !== '';
}
/**

Hi @arnold can you please test the above change? Does it fix to you?

valerio.bozzolan: Hi @arnold can you please test the above change? Does it fix to you?
arnoldUnsubmitted
Not Done
Inline Actions

Is there a way for me to copy that patch? I'm not sure how to do that despite using phabricator for years :)

I could manually make those changes, but I don't want to make typos as I copy it

arnold: Is there a way for me to copy that patch? I'm not sure how to do that despite using phabricator…
valerio.bozzolanUnsubmitted
Done
Inline Actions

Let's continue this discussion here:

T15385: Fix Almanac page /almanac/interface/edit/1/

valerio.bozzolan: Let's continue this discussion here: {T15385}
} }
/** /**
* When rendering to external targets (Email/Asana/etc), we need to include * When rendering to external targets (Email/Asana/etc), we need to include
* more information that users can't obtain later. * more information that users can't obtain later.
*/ */
final protected function isRenderingTargetExternal() { final protected function isRenderingTargetExternal() {
// Right now, this is our best proxy for this: // Right now, this is our best proxy for this:
▲ Show 20 Lines • Show All 147 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0