Changeset View
Changeset View
Standalone View
Standalone View
src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
| Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Lines | protected function renderResultList( | ||||
| $policy_objects = ConpherenceThread::loadViewPolicyObjects( | $policy_objects = ConpherenceThread::loadViewPolicyObjects( | ||||
| $viewer, | $viewer, | ||||
| $conpherences); | $conpherences); | ||||
| $engines = array(); | $engines = array(); | ||||
| $fulltext = $query->getParameter('fulltext'); | $fulltext = $query->getParameter('fulltext'); | ||||
| if (strlen($fulltext) && $conpherences) { | if (phutil_nonempty_string($fulltext) && $conpherences) { | ||||
valerio.bozzolan: ✅ I logged this locally and it seems this is just the user query for fulltext search, and its… | |||||
| $context = $this->loadContextMessages($conpherences, $fulltext); | $context = $this->loadContextMessages($conpherences, $fulltext); | ||||
| $author_phids = array(); | $author_phids = array(); | ||||
| foreach ($context as $phid => $messages) { | foreach ($context as $phid => $messages) { | ||||
| $conpherence = $conpherences[$phid]; | $conpherence = $conpherences[$phid]; | ||||
| $engine = id(new PhabricatorMarkupEngine()) | $engine = id(new PhabricatorMarkupEngine()) | ||||
| ->setViewer($viewer) | ->setViewer($viewer) | ||||
| ▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines | |||||
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0
✅ I logged this locally and it seems this is just the user query for fulltext search, and its input domain is just NULL or string. The phutil_nonempty_string() will report alien values and this is OK.