Differential D25138 Diff 536 src/applications/celerity/controller/CelerityResourceController.php

Changeset View

Standalone View

src/applications/celerity/controller/CelerityResourceController.php

Show First 20 Lines • Show All 107 Lines • ▼ Show 20 Lines	protected function serveResource(array $spec) {

// The "Content-Security-Policy" header has no effect on the actual		// The "Content-Security-Policy" header has no effect on the actual
// resources, only on the main request. Disable it on the resource		// resources, only on the main request. Disable it on the resource
// responses to limit confusion.		// responses to limit confusion.
$response->setDisableContentSecurityPolicy(true);		$response->setDisableContentSecurityPolicy(true);

$range = AphrontRequest::getHTTPHeader('Range');		$range = AphrontRequest::getHTTPHeader('Range');

if (strlen($range)) {		if (phutil_nonempty_string($range)) {
		valerio.bozzolanUnsubmitted Not Done Inline Actions ✅ the default of `getHTTPHeader()` is null (and not false or whatever) so `phutil_nonempty_string` should receive a correct input domain of `string` and `null`. ./src/aphront/AphrontRequest.php public static function getHTTPHeader($name, $default = null, $data = null) valerio.bozzolan: ✅ the default of `getHTTPHeader()` is null (and not false or whatever) so…
$response->setContentLength(strlen($data));		$response->setContentLength(strlen($data));

list($range_begin, $range_end) = $response->parseHTTPRange($range);		list($range_begin, $range_end) = $response->parseHTTPRange($range);

if ($range_begin !== null) {		if ($range_begin !== null) {
if ($range_end !== null) {		if ($range_end !== null) {
$data = substr($data, $range_begin, ($range_end - $range_begin));		$data = substr($data, $range_begin, ($range_end - $range_begin));
} else {		} else {
▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines