Differential D25131 Diff 523 src/aphront/AphrontRequest.php

Changeset View

Standalone View

src/aphront/AphrontRequest.php

Show First 20 Lines • Show All 442 Lines • ▼ Show 20 Lines	/* -( Accessing Request Data )--------------------------------------------- */


public function setCookiePrefix($prefix) {		public function setCookiePrefix($prefix) {
$this->cookiePrefix = $prefix;		$this->cookiePrefix = $prefix;
return $this;		return $this;
}		}

private function getPrefixedCookieName($name) {		private function getPrefixedCookieName($name) {
if (strlen($this->cookiePrefix)) {		if (phutil_nonempty_string($this->cookiePrefix)) {
		valerio.bozzolanUnsubmitted Not Done Inline Actions Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien (like false) should arrive causing the related crash from the phutil check. If an alien value will arrive causing a crash, we can just discuss that specific case again. valerio.bozzolan: Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien…
		valerio.bozzolanUnsubmitted Done Inline Actions Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien (like false) should arrive causing the related crash from the phutil check. If an alien value will arrive causing a crash, we can just discuss that specific case again. valerio.bozzolan: Thanks. This fix for PHP 8.1 should be very OK since the default is NULL and nothing alien…
return $this->cookiePrefix.'_'.$name;		return $this->cookiePrefix.'_'.$name;
} else {		} else {
return $name;		return $name;
}		}
}		}

public function getCookie($name, $default = null) {		public function getCookie($name, $default = null) {
$name = $this->getPrefixedCookieName($name);		$name = $this->getPrefixedCookieName($name);
▲ Show 20 Lines • Show All 511 Lines • Show Last 20 Lines