Page MenuHomePhorge

D26095.1750120708.diff
No OneTemporary

D26095.1750120708.diff

diff --git a/src/future/http/HTTPSFuture.php b/src/future/http/HTTPSFuture.php
--- a/src/future/http/HTTPSFuture.php
+++ b/src/future/http/HTTPSFuture.php
@@ -552,9 +552,7 @@
// NOTE: We want to use keepalive if possible. Return the handle to a
// pool for the domain; don't close it.
- if ($this->shouldReuseHandles()) {
- self::$pool[$domain][] = $curl;
- }
+ self::$pool[$domain][] = $curl;
if ($is_download) {
if ($this->downloadHandle) {
@@ -830,20 +828,6 @@
return $bytes;
}
- private function shouldReuseHandles() {
- $curl_version = curl_version();
- $version = idx($curl_version, 'version');
-
- // NOTE: cURL 7.43.0 has a bug where the POST body length is not recomputed
- // properly when a handle is reused. For this version of cURL, disable
- // handle reuse and accept a small performance penalty. See T8654.
- if ($version == '7.43.0') {
- return false;
- }
-
- return true;
- }
-
private function isDownload() {
return ($this->downloadPath !== null);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Jun 17, 00:38 (15 h, 37 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1880142
Default Alt Text
D26095.1750120708.diff (1 KB)

Event Timeline