Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F5486269
D26095.1750120708.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D26095.1750120708.diff
View Options
diff --git a/src/future/http/HTTPSFuture.php b/src/future/http/HTTPSFuture.php
--- a/src/future/http/HTTPSFuture.php
+++ b/src/future/http/HTTPSFuture.php
@@ -552,9 +552,7 @@
// NOTE: We want to use keepalive if possible. Return the handle to a
// pool for the domain; don't close it.
- if ($this->shouldReuseHandles()) {
- self::$pool[$domain][] = $curl;
- }
+ self::$pool[$domain][] = $curl;
if ($is_download) {
if ($this->downloadHandle) {
@@ -830,20 +828,6 @@
return $bytes;
}
- private function shouldReuseHandles() {
- $curl_version = curl_version();
- $version = idx($curl_version, 'version');
-
- // NOTE: cURL 7.43.0 has a bug where the POST body length is not recomputed
- // properly when a handle is reused. For this version of cURL, disable
- // handle reuse and accept a small performance penalty. See T8654.
- if ($version == '7.43.0') {
- return false;
- }
-
- return true;
- }
-
private function isDownload() {
return ($this->downloadPath !== null);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Jun 17, 00:38 (15 h, 37 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1880142
Default Alt Text
D26095.1750120708.diff (1 KB)
Attached To
Mode
D26095: Remove special handling of curl 7.43.0 in HTTPSFuture
Attached
Detach File
Event Timeline
Log In to Comment