Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F4825513
D26034.1749323492.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
776 B
Referenced Files
None
Subscribers
None
D26034.1749323492.diff
View Options
diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
--- a/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
+++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php
@@ -23,7 +23,8 @@
$client_id_parameter = $request->getStr('client_id');
$client_id_header = idx($_SERVER, 'PHP_AUTH_USER');
- if (strlen($client_id_parameter) && strlen($client_id_header)) {
+ if (phutil_nonempty_string($client_id_parameter) &&
+ phutil_nonempty_string($client_id_header)) {
if ($client_id_parameter !== $client_id_header) {
throw new Exception(
pht(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jun 7, 19:11 (3 h, 34 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1753987
Default Alt Text
D26034.1749323492.diff (776 B)
Attached To
Mode
D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController
Attached
Detach File
Event Timeline
Log In to Comment