Page MenuHomePhorge
Files F3827632

D25979.1746039665.diff
No OneTemporary
Actions

D25979.1746039665.diff
View Options

diff --git a/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php b/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php
--- a/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php
+++ b/src/applications/drydock/worker/DrydockLeaseUpdateWorker.php
@@ -169,7 +169,7 @@
* acquire the lease.
*
* @param DrydockLease $lease Requested lease.
- * @return void
+ * @return DrydockResource
* @task allocator
*/
private function executeAllocator(DrydockLease $lease) {
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
--- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
@@ -531,8 +531,6 @@
/**
* Attempt to deliver an email immediately, in this process.
- *
- * @return void
*/
public function sendNow() {
if ($this->getStatus() != PhabricatorMailOutboundStatus::STATUS_QUEUE) {
diff --git a/src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php b/src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php
--- a/src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php
+++ b/src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php
@@ -35,7 +35,7 @@
$handle->setName($email->getAddress());
}
- return null;
+ return;
}
}
diff --git a/src/applications/search/query/PhabricatorSearchDocumentQuery.php b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
--- a/src/applications/search/query/PhabricatorSearchDocumentQuery.php
+++ b/src/applications/search/query/PhabricatorSearchDocumentQuery.php
@@ -105,7 +105,7 @@
protected function nextPage(array $page) {
// We already updated the internal offset in `loadPage()` after loading
// results, so we do not need to make any additional state updates here.
- return $this;
+ return;
}
}
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -794,7 +794,6 @@
* query.
* @param PhabricatorCursorPagedPolicyAwareQuery $query Query to constrain.
* @param wild $value Constraint provided by the user.
- * @return void
* @task appsearch
*/
public function applyApplicationSearchConstraintToQuery(
@@ -818,7 +817,6 @@
* form.
* @param AphrontFormView $form The form to update.
* @param wild $value Value from the saved query.
- * @return void
* @task appsearch
*/
public function appendToApplicationSearchForm(
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
@@ -48,7 +48,7 @@
*
* @param PhabricatorCustomFieldInterface $object Object to read field values
* for.
- * @return void
+ * @return $this
*/
public function readFieldsFromStorage(
PhabricatorCustomFieldInterface $object) {
diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
--- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
+++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
@@ -74,7 +74,7 @@
// (Before T13266, we raised an exception here, but since "nextPage()" is
// now called even if we don't page we can't do that anymore. Just do
// nothing instead.)
- return null;
+ return;
}
protected function loadPage() {
diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
--- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
+++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
@@ -86,7 +86,6 @@
* is the first execution.
* @param int $this_event Scheduled epoch of this execution. This may not be
* the same as the current time.
- * @return void
*/
public function executeTrigger($last_event, $this_event) {
return $this->getAction()->execute($last_event, $this_event);

File Metadata

Mime Type
text/plain
Expires
Wed, Apr 30, 19:01 (20 h, 2 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1427459
Default Alt Text
D25979.1746039665.diff (4 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0