Page MenuHomePhorge
Files F3353440

D25944.1743838614.diff
No OneTemporary
Actions

D25944.1743838614.diff
View Options

diff --git a/src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php b/src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php
--- a/src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php
+++ b/src/applications/dashboard/interface/PhabricatorDashboardPanelContainerInterface.php
@@ -5,7 +5,7 @@
/**
* Return a list of Dashboard Panel PHIDs used by this container.
*
- * @return list<phid>
+ * @return list<string> Dashboard panel PHIDs used by this container.
*/
public function getDashboardPanelContainerPanelPHIDs();
diff --git a/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php b/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
--- a/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
+++ b/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php
@@ -145,8 +145,8 @@
/**
* Get a list of users to act as when publishing into JIRA.
*
- * @return list<phid> Candidate user PHIDs to act as when publishing this
- * story.
+ * @return list<string> Candidate user PHIDs to act as when publishing this
+ * story.
* @task internal
*/
private function findUsersToPossess() {
diff --git a/src/applications/harbormaster/interface/HarbormasterBuildableInterface.php b/src/applications/harbormaster/interface/HarbormasterBuildableInterface.php
--- a/src/applications/harbormaster/interface/HarbormasterBuildableInterface.php
+++ b/src/applications/harbormaster/interface/HarbormasterBuildableInterface.php
@@ -11,7 +11,7 @@
* buildable (the diff), but for commits the buildable (the commit) is more
* meaningful than the container (the repository).
*
- * @return phid Related object PHID most meaningful for human viewers.
+ * @return string Related object PHID most meaningful for human viewers.
*/
public function getHarbormasterBuildableDisplayPHID();
diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php
--- a/src/applications/maniphest/query/ManiphestTaskQuery.php
+++ b/src/applications/maniphest/query/ManiphestTaskQuery.php
@@ -809,8 +809,8 @@
* ...we ignore the single project, as every result is in that project. (In
* the case that there are several "any" projects, we do not ignore them.)
*
- * @return list<phid> Project PHIDs which should be ignored in query
- * construction.
+ * @return list<string> Project PHIDs which should be ignored in query
+ * construction.
*/
private function getIgnoreGroupedProjectPHIDs() {
// Maybe we should also exclude the "OPERATOR_NOT" PHIDs? It won't
diff --git a/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php b/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
--- a/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
+++ b/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
@@ -276,7 +276,7 @@
*
* @param list<string> $to List of To PHIDs.
* @param list<string> $cc List of CC PHIDs.
- * @return pair<list<phid>, list<phid>> Expanded PHID lists.
+ * @return pair<list<string>, list<string>> Expanded PHID lists.
*/
private function expandRecipientPHIDs(array $to, array $cc) {
$to_result = array();
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
--- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
@@ -826,8 +826,8 @@
* Note that this expands recipients into their members, because delivery
* is never directly attempted to aggregate actors like projects.
*
- * @return list<phid> A list of all recipients to whom delivery will be
- * attempted.
+ * @return list<string> A list of all recipients to whom delivery will be
+ * attempted.
* @task recipients
*/
public function buildRecipientList() {
diff --git a/src/applications/phid/query/PhabricatorObjectQuery.php b/src/applications/phid/query/PhabricatorObjectQuery.php
--- a/src/applications/phid/query/PhabricatorObjectQuery.php
+++ b/src/applications/phid/query/PhabricatorObjectQuery.php
@@ -198,7 +198,7 @@
*
* @param PhabricatorUser $viewer Viewer.
* @param list<string> $phids List of ostensibly valid PHIDs.
- * @return list<phid> List of invalid or restricted PHIDs.
+ * @return list<string> List of invalid or restricted PHIDs.
*/
public static function loadInvalidPHIDsForViewer(
PhabricatorUser $viewer,
diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
--- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
@@ -734,7 +734,7 @@
* @param string $key Key to read in the request.
* @param list<string> $allow_types (optional) Other permitted PHID type
* constants.
- * @return list<phid> List of user PHIDs and selector functions.
+ * @return list<string> List of user PHIDs and selector functions.
* @task read
*/
protected function readUsersFromRequest(
@@ -785,7 +785,7 @@
*
* @param AphrontRequest $request Request to read PHIDs from.
* @param string $key Key to read in the request.
- * @return list<phid> List of object PHIDs.
+ * @return list<string> List of object PHIDs.
* @task read
*/
protected function readSubscribersFromRequest(
@@ -810,7 +810,7 @@
* @param string $key Key to read in the request.
* @param list<string> $allow_types (optional) List of permitted PHID
* type constants.
- * @return list<phid> List of object PHIDs.
+ * @return list<string> List of object PHIDs.
*
* @task read
*/
diff --git a/src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php b/src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
--- a/src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
+++ b/src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
@@ -213,7 +213,7 @@
* can intentionally pass any value in (including `null`).
*
* @param wild $object
- * @return phid|null
+ * @return string|null Space PHID of the object, or null.
*/
public static function getObjectSpacePHID($object) {
if (!$object) {
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -4762,7 +4762,7 @@
* conflicting projects.
*
* @param list<string> $phids List of project PHIDs.
- * @return list<phid> List with conflicts removed.
+ * @return list<string> List of project PHIDs with conflicts removed.
*/
private function applyProjectConflictRules(array $phids) {
if (!$phids) {
diff --git a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
--- a/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
+++ b/src/infrastructure/edges/query/PhabricatorEdgeQuery.php
@@ -123,7 +123,7 @@
*
* @param string $src_phid Source PHID.
* @param string $edge_type Edge type constant.
- * @return list<phid> List of destination PHIDs.
+ * @return list<string> List of destination PHIDs.
*/
public static function loadDestinationPHIDs($src_phid, $edge_type) {
$edges = id(new PhabricatorEdgeQuery())
@@ -260,7 +260,7 @@
* select all.
* @param list $types (optional) List of edge types to select, or empty to
* select all.
- * @return list<phid> List of matching destination PHIDs.
+ * @return list<string> List of matching destination PHIDs.
*/
public function getDestinationPHIDs(
array $src_phids = array(),
diff --git a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
--- a/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
+++ b/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php
@@ -433,7 +433,7 @@
* between objects which do not exist (or, at least, were filtered at the
* content level) and objects which exist but aren't visible.
*
- * @return map<phid, phid> Map of object PHIDs which were filtered
+ * @return map<string, string> Map of object PHIDs which were filtered
* by policies.
* @task exec
*/
@@ -552,7 +552,7 @@
*
* PHIDs which are "in flight" are actively being queried for.
*
- * @return map<phid, phid> PHIDs currently in flight.
+ * @return map<string, string> PHIDs currently in flight.
*/
public function getPHIDsInFlight() {
$results = $this->inFlightPHIDs;
diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php
--- a/src/infrastructure/storage/lisk/LiskDAO.php
+++ b/src/infrastructure/storage/lisk/LiskDAO.php
@@ -1187,7 +1187,7 @@
/**
* Generate a new PHID, used by CONFIG_AUX_PHID.
*
- * @return phid Unique, newly allocated PHID.
+ * @return string Unique, newly allocated PHID.
*
* @task hook
*/

File Metadata

Mime Type
text/plain
Expires
Sat, Apr 5, 07:36 (1 h, 53 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1271482
Default Alt Text
D25944.1743838614.diff (9 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0