ArcanistModifierOrderingXHPASTLinterRule.php
No OneTemporary
Actions

Size

2 KB

Referenced Files

None

Subscribers

None

ArcanistModifierOrderingXHPASTLinterRule.php
View Options

	<?php

	final class ArcanistModifierOrderingXHPASTLinterRule
	extends ArcanistXHPASTLinterRule {

	const ID = 71;

	public function getLintName() {
	return pht('Modifier Ordering');
	}

	public function getLintSeverity() {
	return ArcanistLintSeverity::SEVERITY_ADVICE;
	}

	public function process(XHPASTNode $root) {
	$this->lintMethodModifierOrdering($root);
	$this->lintPropertyModifierOrdering($root);
	}

	private function lintMethodModifierOrdering(XHPASTNode $root) {
	static $modifiers = array(
	'abstract',
	'final',
	'public',
	'protected',
	'private',
	'static',
	);

	$methods = $root->selectDescendantsOfType('n_METHOD_MODIFIER_LIST');

	foreach ($methods as $method) {
	$modifier_ordering = array_values(
	mpull($method->getChildren(), 'getConcreteString'));
	$expected_modifier_ordering = array_values(
	array_intersect(
	$modifiers,
	$modifier_ordering));

	if (count($modifier_ordering) != count($expected_modifier_ordering)) {
	continue;
	}

	if ($modifier_ordering != $expected_modifier_ordering) {
	$this->raiseLintAtNode(
	$method,
	pht('Non-conventional modifier ordering.'),
	implode(' ', $expected_modifier_ordering));
	}
	}
	}

	private function lintPropertyModifierOrdering(XHPASTNode $root) {
	static $modifiers = array(
	'public',
	'protected',
	'private',
	'static',
	);

	$properties = $root->selectDescendantsOfType(
	'n_CLASS_MEMBER_MODIFIER_LIST');

	foreach ($properties as $property) {
	$modifier_ordering = array_values(
	mpull($property->getChildren(), 'getConcreteString'));
	$expected_modifier_ordering = array_values(
	array_intersect(
	$modifiers,
	$modifier_ordering));

	if (count($modifier_ordering) != count($expected_modifier_ordering)) {
	continue;
	}

	if ($modifier_ordering != $expected_modifier_ordering) {
	$this->raiseLintAtNode(
	$property,
	pht('Non-conventional modifier ordering.'),
	implode(' ', $expected_modifier_ordering));
	}
	}
	}

	}

File Metadata

Mime Type: text/x-php
Expires: Thu, Mar 27, 00:46 (1 w, 3 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1120243
Default Alt Text: ArcanistModifierOrderingXHPASTLinterRule.php (2 KB)

ArcanistModifierOrderingXHPASTLinterRule.phpNo OneTemporaryActions

ArcanistModifierOrderingXHPASTLinterRule.phpView Options

File Metadata

Event Timeline

ArcanistModifierOrderingXHPASTLinterRule.php
No OneTemporary
Actions

ArcanistModifierOrderingXHPASTLinterRule.php
View Options