Page MenuHomePhorge

D25212.1740279997.diff
No OneTemporary

D25212.1740279997.diff

diff --git a/src/applications/macro/engine/PhabricatorMemeEngine.php b/src/applications/macro/engine/PhabricatorMemeEngine.php
--- a/src/applications/macro/engine/PhabricatorMemeEngine.php
+++ b/src/applications/macro/engine/PhabricatorMemeEngine.php
@@ -182,7 +182,8 @@
// changes to the image.
$above_text = $this->getAboveText();
$below_text = $this->getBelowText();
- if (!strlen(trim($above_text)) && !strlen(trim($below_text))) {
+ if (($above_text === null || !phutil_nonempty_string(trim($above_text))) &&
+ ($below_text === null || !phutil_nonempty_string(trim($below_text)))) {
return $template_data;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Feb 23, 03:06 (4 d, 8 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1146660
Default Alt Text
D25212.1740279997.diff (656 B)

Event Timeline