Page MenuHomePhorge
Files F2981661

D25884.1739921451.diff
No OneTemporary
Actions

D25884.1739921451.diff
View Options

diff --git a/src/applications/herald/action/HeraldAction.php b/src/applications/herald/action/HeraldAction.php
--- a/src/applications/herald/action/HeraldAction.php
+++ b/src/applications/herald/action/HeraldAction.php
@@ -122,6 +122,9 @@
return $this;
}
+ /*
+ * @return HeraldAdapter HeraldAdapter class of the action
+ **/
final public function getAdapter() {
return $this->adapter;
}
diff --git a/src/applications/herald/engine/HeraldEffect.php b/src/applications/herald/engine/HeraldEffect.php
--- a/src/applications/herald/engine/HeraldEffect.php
+++ b/src/applications/herald/engine/HeraldEffect.php
@@ -13,6 +13,9 @@
return $this;
}
+ /**
+ * @return string PHID of the object that Herald is applied on
+ */
public function getObjectPHID() {
return $this->objectPHID;
}
@@ -22,6 +25,9 @@
return $this;
}
+ /**
+ * @return string ACTIONCONST of the HeraldAction
+ */
public function getAction() {
return $this->action;
}
@@ -31,6 +37,9 @@
return $this;
}
+ /**
+ * @return array|null
+ */
public function getTarget() {
return $this->target;
}
@@ -40,6 +49,9 @@
return $this;
}
+ /**
+ * @return HeraldRule
+ */
public function getRule() {
return $this->rule;
}
@@ -49,6 +61,10 @@
return $this;
}
+ /**
+ * @return string Reason why Herald effect was applied, for example
+ * "Conditions were met for H123 RuleName"
+ */
public function getReason() {
return $this->reason;
}
diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php
--- a/src/applications/herald/storage/HeraldRule.php
+++ b/src/applications/herald/storage/HeraldRule.php
@@ -265,6 +265,9 @@
->addString($this->getName());
}
+ /**
+ * @return string Name of the rule, for example "H123 RuleName (Disabled)"
+ */
public function getEditorDisplayName() {
$name = pht('%s %s', $this->getMonogram(), $this->getName());

File Metadata

Mime Type
text/plain
Expires
Tue, Feb 18, 23:30 (3 d, 4 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1174740
Default Alt Text
D25884.1739921451.diff (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0