Page MenuHomePhorge

D25184.1738104255.diff
No OneTemporary

D25184.1738104255.diff

diff --git a/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php b/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
--- a/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
+++ b/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
@@ -17,16 +17,16 @@
$target_identifier = head($target_tokens);
}
- if (!strlen($target_identifier)) {
+ if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $request->getStr('target');
}
- if (!strlen($target_identifier)) {
+ if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $this->getMode();
}
$target = null;
- if (strlen($target_identifier)) {
+ if (phutil_nonempty_string($target_identifier)) {
$targets = array();
if (ctype_digit($target_identifier)) {
@@ -74,7 +74,7 @@
}
$errors = array();
- if (strlen($target_identifier)) {
+ if (phutil_nonempty_string($target_identifier)) {
if (!$target) {
$errors[] = pht('Choose a valid object.');
} else if (!$can_edit) {

File Metadata

Mime Type
text/plain
Expires
Tue, Jan 28, 22:44 (4 d, 8 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1149794
Default Alt Text
D25184.1738104255.diff (1 KB)

Event Timeline