Page MenuHomePhorge

D25222.1737855700.diff
No OneTemporary

D25222.1737855700.diff

diff --git a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
--- a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
+++ b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
@@ -97,8 +97,17 @@
return 'fa-calculator';
}
+ /**
+ * Normalize your Story Points from generic stuff to double or null.
+ * @param mixed $value Your raw Story Points
+ * @return double|null
+ */
private function getValueForPoints($value) {
- if (!strlen($value)) {
+ // The Point can be various types also thanks to Conduit API
+ // like integers, floats, null, and strings of course.
+ // Everything meaningful must be printable as a string.
+ $is_empty = phutil_string_cast($value) === '';
+ if ($is_empty) {
$value = null;
}
if ($value !== null) {

File Metadata

Mime Type
text/plain
Expires
Sun, Jan 26, 01:41 (6 d, 21 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1146454
Default Alt Text
D25222.1737855700.diff (918 B)

Event Timeline