Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2932541
D25187.1737739194.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
842 B
Referenced Files
None
Subscribers
None
D25187.1737739194.diff
View Options
diff --git a/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php b/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
--- a/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
+++ b/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
@@ -27,12 +27,12 @@
$old_value = $this->getOldValue();
$new_value = $this->getNewValue();
- if (!strlen($old_value)) {
+ if (!phutil_nonempty_string($old_value)) {
return pht(
'%s set the alternate text for this file to %s.',
$this->renderAuthor(),
$this->renderNewValue());
- } else if (!strlen($new_value)) {
+ } else if (!phutil_nonempty_string($new_value)) {
return pht(
'%s removed the alternate text for this file (was %s).',
$this->renderAuthor(),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jan 24, 17:19 (5 d, 21 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1130977
Default Alt Text
D25187.1737739194.diff (842 B)
Attached To
Mode
D25187: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a File page when Alt Text was altered
Attached
Detach File
Event Timeline
Log In to Comment