D25175.1737690617.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25175.1737690617.diff
View Options

	diff --git a/src/applications/auth/constants/PhabricatorCookies.php b/src/applications/auth/constants/PhabricatorCookies.php
	--- a/src/applications/auth/constants/PhabricatorCookies.php
	+++ b/src/applications/auth/constants/PhabricatorCookies.php
	@@ -164,7 +164,7 @@
	// Old cookies look like: /uri
	// New cookies look like: timestamp,/uri

	- if (!strlen($cookie)) {
	+ if (!phutil_nonempty_string($cookie)) {
	return null;
	}

	diff --git a/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php b/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
	--- a/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
	+++ b/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
	@@ -91,9 +91,13 @@
	}

	public function isRawCacheDataValid(PhabricatorUser $user, $key, $data) {
	- $parts = explode(',', $data, 2);
	- $version = reset($parts);
	- return ($version === $this->getCacheVersion($user));
	+ if ($data) {
	+ $parts = explode(',', $data, 2);
	+ $version = reset($parts);
	+ return ($version === $this->getCacheVersion($user));
	+ } else {
	+ return false;
	+ }
	}

	private function getCacheVersion(PhabricatorUser $user) {