Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2930403
D25212.1737677313.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
640 B
Referenced Files
None
Subscribers
None
D25212.1737677313.diff
View Options
diff --git a/src/applications/macro/engine/PhabricatorMemeEngine.php b/src/applications/macro/engine/PhabricatorMemeEngine.php
--- a/src/applications/macro/engine/PhabricatorMemeEngine.php
+++ b/src/applications/macro/engine/PhabricatorMemeEngine.php
@@ -182,7 +182,8 @@
// changes to the image.
$above_text = $this->getAboveText();
$below_text = $this->getBelowText();
- if (!strlen(trim($above_text)) && !strlen(trim($below_text))) {
+ if ((!$above_text || !phutil_nonempty_string(trim($above_text))) &&
+ (!$below_text || !phutil_nonempty_string(trim($below_text)))) {
return $template_data;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jan 24, 00:08 (3 d, 14 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1118516
Default Alt Text
D25212.1737677313.diff (640 B)
Attached To
Mode
D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment
Attached
Detach File
Event Timeline
Log In to Comment