Page MenuHomePhorge

D25264.1737424828.diff
No OneTemporary

D25264.1737424828.diff

diff --git a/src/applications/differential/customfield/DifferentialBranchField.php b/src/applications/differential/customfield/DifferentialBranchField.php
--- a/src/applications/differential/customfield/DifferentialBranchField.php
+++ b/src/applications/differential/customfield/DifferentialBranchField.php
@@ -39,11 +39,11 @@
$branch = $diff->getBranch();
$bookmark = $diff->getBookmark();
- if (strlen($branch) && strlen($bookmark)) {
+ if (phutil_nonempty_string($branch) && phutil_nonempty_string($bookmark)) {
return pht('%s (bookmark) on %s (branch)', $bookmark, $branch);
- } else if (strlen($bookmark)) {
+ } else if (phutil_nonempty_string($bookmark)) {
return pht('%s (bookmark)', $bookmark);
- } else if (strlen($branch)) {
+ } else if (phutil_nonempty_string($branch)) {
$onto = $diff->loadTargetBranch();
if (strlen($onto) && ($onto !== $branch)) {
return pht(

File Metadata

Mime Type
text/plain
Expires
Tue, Jan 21, 02:00 (1 d, 4 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1140842
Default Alt Text
D25264.1737424828.diff (942 B)

Event Timeline