Page MenuHomePhorge

D25170.1737394990.diff
No OneTemporary

D25170.1737394990.diff

diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
--- a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
+++ b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
@@ -39,7 +39,7 @@
$parameters = array();
$raw_parameters = $request->getStr('parameters');
- if (strlen($raw_parameters)) {
+ if (phutil_nonempty_string($raw_parameters)) {
try {
$parameters = phutil_json_decode($raw_parameters);
} catch (PhutilJSONParserException $ex) {
diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php
--- a/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php
+++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php
@@ -207,7 +207,11 @@
}
protected function sliceResults(array $results) {
- $offset = $this->getOffset();
+ if ($this->getOffset()) {
+ $offset = $this->getOffset();
+ } else {
+ $offset = 0;
+ }
$limit = $this->getLimit();
if ($offset || $limit) {

File Metadata

Mime Type
text/plain
Expires
Mon, Jan 20, 17:43 (1 d, 12 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1111927
Default Alt Text
D25170.1737394990.diff (1 KB)

Event Timeline