Page MenuHomePhorge
Files F2896453

No OneTemporary
Actions

View Options

diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
index 0d7e79c32f..2497a7ed24 100644
--- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
+++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
@@ -1,51 +1,45 @@
<?php
final class PhabricatorSubscriptionsListController
extends PhabricatorController {
- private $phid;
-
- public function willProcessRequest(array $data) {
- $this->phid = idx($data, 'phid');
- }
-
public function shouldAllowPublic() {
return true;
}
- public function processRequest() {
- $request = $this->getRequest();
-
+ public function handleRequest(AphrontRequest $request) {
$viewer = $request->getUser();
- $phid = $this->phid;
-
$object = id(new PhabricatorObjectQuery())
->setViewer($viewer)
- ->withPHIDs(array($phid))
+ ->withPHIDs(array($request->getURIData('phid')))
->executeOne();
+ if (!$object) {
+ return new Aphront404Response();
+ }
- if ($object instanceof PhabricatorSubscribableInterface) {
- $subscriber_phids = PhabricatorSubscribersQuery::loadSubscribersForPHID(
- $phid);
+ if (!($object instanceof PhabricatorSubscribableInterface)) {
+ return new Aphront404Response();
}
- $handle_phids = $subscriber_phids;
+ $phid = $object->getPHID();
+
+ $handle_phids = PhabricatorSubscribersQuery::loadSubscribersForPHID($phid);
$handle_phids[] = $phid;
$handles = id(new PhabricatorHandleQuery())
->setViewer($viewer)
->withPHIDs($handle_phids)
->execute();
$object_handle = $handles[$phid];
$dialog = id(new SubscriptionListDialogBuilder())
->setViewer($viewer)
->setTitle(pht('Subscribers'))
->setObjectPHID($phid)
->setHandles($handles)
->buildDialog();
return id(new AphrontDialogResponse())->setDialog($dialog);
}
}

File Metadata

Mime Type
text/x-diff
Expires
Jan 19 2025, 23:07 (6 w, 3 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1129710
Default Alt Text
(2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0