No OneTemporary
Actions

Size

43 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/repository/controller/PhabricatorRepositoryEditController.php b/src/applications/repository/controller/PhabricatorRepositoryEditController.php
	index 0a1a0ca364..b4824bd4bc 100644
	--- a/src/applications/repository/controller/PhabricatorRepositoryEditController.php
	+++ b/src/applications/repository/controller/PhabricatorRepositoryEditController.php
	@@ -1,685 +1,695 @@
	<?php

	final class PhabricatorRepositoryEditController
	extends PhabricatorRepositoryController {

	private $id;
	private $view;
	private $repository;
	private $sideNav;

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	$this->view = idx($data, 'view');
	}

	public function processRequest() {

	$request = $this->getRequest();

	$repository = id(new PhabricatorRepository())->load($this->id);
	if (!$repository) {
	return new Aphront404Response();
	}

	$views = array(
	'basic' => 'Basics',
	'tracking' => 'Tracking',
	);

	$this->repository = $repository;

	if (!isset($views[$this->view])) {
	$this->view = head_key($views);
	}

	$nav = new AphrontSideNavFilterView();
	$base_uri = new PhutilURI('/repository/edit/'.$repository->getID().'/');
	$nav->setBaseURI($base_uri);
	foreach ($views as $view => $name) {
	$nav->addFilter($view, $name);
	}
	$nav->selectFilter($this->view, null);

	$nav->appendChild($this->renderDaemonNotice());

	$this->sideNav = $nav;

	switch ($this->view) {
	case 'basic':
	return $this->processBasicRequest();
	case 'tracking':
	return $this->processTrackingRequest();
	default:
	throw new Exception("Unknown view.");
	}
	}

	protected function processBasicRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();
	$repository = $this->repository;
	$repository_id = $repository->getID();

	$errors = array();

	$e_name = true;

	if ($request->isFormPost()) {
	$repository->setName($request->getStr('name'));

	if (!strlen($repository->getName())) {
	$e_name = 'Required';
	$errors[] = 'Repository name is required.';
	} else {
	$e_name = null;
	}

	$repository->setDetail('description', $request->getStr('description'));
	$repository->setDetail('encoding', $request->getStr('encoding'));

	if (!$errors) {
	$repository->save();
	return id(new AphrontRedirectResponse())
	->setURI('/repository/edit/'.$repository_id.'/basic/?saved=true');
	}
	}

	$error_view = null;
	if ($errors) {
	$error_view = new AphrontErrorView();
	$error_view->setErrors($errors);
	$error_view->setTitle('Form Errors');
	} else if ($request->getStr('saved')) {
	$error_view = new AphrontErrorView();
	$error_view->setSeverity(AphrontErrorView::SEVERITY_NOTICE);
	$error_view->setTitle('Changes Saved');
	$error_view->appendChild('Repository changes were saved.');
	}

	$encoding_doc_link = PhabricatorEnv::getDoclink(
	'article/User_Guide_UTF-8_and_Character_Encoding.html');

	$form = new AphrontFormView();
	$form
	->setUser($user)
	->setAction('/repository/edit/'.$repository->getID().'/')
	->appendChild(
	id(new AphrontFormTextControl())
	->setLabel('Name')
	->setName('name')
	->setValue($repository->getName())
	->setError($e_name)
	->setCaption('Human-readable repository name.'))
	->appendChild(
	id(new AphrontFormTextAreaControl())
	->setLabel('Description')
	->setName('description')
	->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
	->setValue($repository->getDetail('description')))
	->appendChild(
	id(new AphrontFormStaticControl())
	->setLabel('Callsign')
	->setName('callsign')
	->setValue($repository->getCallsign()))
	->appendChild(hsprintf('
	<p class="aphront-form-instructions">'.
	'If source code in this repository uses a character '.
	'encoding other than UTF-8 (for example, ISO-8859-1), '.
	'specify it here. You can usually leave this field blank. '.
	'See User Guide: '.
	'<a href="%s">UTF-8 and Character Encoding</a> for more information.'.
	'</p>',
	$encoding_doc_link))
	->appendChild(
	id(new AphrontFormTextControl())
	->setLabel('Encoding')
	->setName('encoding')
	->setValue($repository->getDetail('encoding')))
	->appendChild(
	id(new AphrontFormStaticControl())
	->setLabel('Type')
	->setName('type')
	->setValue($repository->getVersionControlSystem()))
	->appendChild(
	id(new AphrontFormStaticControl())
	->setLabel('ID')
	->setValue($repository->getID()))
	->appendChild(
	id(new AphrontFormStaticControl())
	->setLabel('PHID')
	->setValue($repository->getPHID()))
	->appendChild(
	id(new AphrontFormSubmitControl())
	->setValue('Save'));

	$panel = new AphrontPanelView();
	$panel->setHeader('Edit Repository');
	$panel->appendChild($form);
	$panel->setWidth(AphrontPanelView::WIDTH_FORM);
	$panel->setNoBackground();

	$nav = $this->sideNav;

	$nav->appendChild($error_view);
	$nav->appendChild($panel);

	return $this->buildStandardPageResponse(
	$nav,
	array(
	'title' => 'Edit Repository',
	));
	}

	private function processTrackingRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();
	$repository = $this->repository;
	$repository_id = $repository->getID();

	$errors = array();

	$e_uri = null;
	$e_path = null;

	$is_git = false;
	$is_svn = false;
	$is_mercurial = false;

	$e_ssh_key = null;
	$e_ssh_keyfile = null;
	$e_branch = null;

	switch ($repository->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$is_git = true;
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$is_svn = true;
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$is_mercurial = true;
	break;
	default:
	throw new Exception("Unsupported VCS!");
	}

	$has_branches = ($is_git \|\| $is_mercurial);
	$has_local = ($is_git \|\| $is_mercurial);
	$has_branch_filter = ($is_git);
	$has_auth_support = $is_svn;

	if ($request->isFormPost()) {
	$tracking = ($request->getStr('tracking') == 'enabled' ? true : false);
	$repository->setDetail('tracking-enabled', $tracking);
	$repository->setDetail('remote-uri', $request->getStr('uri'));
	if ($has_local) {
	$repository->setDetail('local-path', $request->getStr('path'));
	}

	if ($has_branch_filter) {
	$branch_filter = $request->getStrList('branch-filter');
	$branch_filter = array_fill_keys($branch_filter, true);

	$repository->setDetail('branch-filter', $branch_filter);

	$close_commits_filter = $request->getStrList('close-commits-filter');
	$close_commits_filter = array_fill_keys($close_commits_filter, true);

	$repository->setDetail('close-commits-filter', $close_commits_filter);
	}

	$repository->setDetail(
	'disable-autoclose',
	$request->getStr('autoclose') == 'disabled' ? true : false);

	$repository->setDetail(
	'pull-frequency',
	max(1, $request->getInt('frequency')));

	if ($has_branches) {
	$repository->setDetail(
	'default-branch',
	$request->getStr('default-branch'));
	if ($is_git) {
	$branch_name = $repository->getDetail('default-branch');
	if (strpos($branch_name, '/') !== false) {
	$e_branch = 'Invalid';
	$errors[] = "Your branch name should not specify an explicit ".
	"remote. For instance, use 'master', not ".
	"'origin/master'.";
	}
	}
	}

	$repository->setDetail(
	'default-owners-path',
	$request->getStr(
	'default-owners-path',
	'/'));

	$repository->setDetail('ssh-login', $request->getStr('ssh-login'));
	$repository->setDetail('ssh-key', $request->getStr('ssh-key'));
	$repository->setDetail('ssh-keyfile', $request->getStr('ssh-keyfile'));

	$repository->setDetail('http-login', $request->getStr('http-login'));
	$repository->setDetail('http-pass', $request->getStr('http-pass'));

	+ $repository->setDetail('show-user', $request->getInt('show-user'));
	+
	if ($repository->getDetail('ssh-key') &&
	$repository->getDetail('ssh-keyfile')) {
	$errors[] =
	"Specify only one of 'SSH Private Key' and 'SSH Private Key File', ".
	"not both.";
	$e_ssh_key = 'Choose Only One';
	$e_ssh_keyfile = 'Choose Only One';
	}

	$repository->setDetail(
	'herald-disabled',
	$request->getInt('herald-disabled', 0));

	if ($is_svn) {
	$repository->setUUID($request->getStr('uuid'));
	$subpath = ltrim($request->getStr('svn-subpath'), '/');
	if ($subpath) {
	$subpath = rtrim($subpath, '/').'/';
	}
	$repository->setDetail('svn-subpath', $subpath);
	}

	if ($tracking) {
	if (!$repository->getDetail('remote-uri')) {
	$e_uri = 'Required';
	$errors[] = "Repository URI is required.";
	} else if ($is_svn &&
	!preg_match('@/$@', $repository->getDetail('remote-uri'))) {

	$e_uri = 'Invalid';
	$errors[] = 'Subversion Repository Root must end in a slash ("/").';
	} else {
	$e_uri = null;
	}

	if ($has_local) {
	if (!$repository->getDetail('local-path')) {
	$e_path = 'Required';
	$errors[] = "Local path is required.";
	} else {
	$e_path = null;
	}
	}
	}

	if (!$errors) {
	$repository->save();
	return id(new AphrontRedirectResponse())
	->setURI('/repository/edit/'.$repository_id.'/tracking/?saved=true');
	}
	}

	$error_view = null;
	if ($errors) {
	$error_view = new AphrontErrorView();
	$error_view->setErrors($errors);
	$error_view->setTitle('Form Errors');
	} else if ($request->getStr('saved')) {
	$error_view = new AphrontErrorView();
	$error_view->setSeverity(AphrontErrorView::SEVERITY_NOTICE);
	$error_view->setTitle('Changes Saved');
	$error_view->appendChild('Tracking changes were saved.');
	} else if (!$repository->isTracked()) {
	$error_view = new AphrontErrorView();
	$error_view->setSeverity(AphrontErrorView::SEVERITY_WARNING);
	$error_view->setTitle('Repository Not Tracked');
	$error_view->appendChild(
	'Tracking is currently "Disabled" for this repository, so it will '.
	'not be imported into Phabricator. You can enable it below.');
	}

	switch ($repository->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$is_git = true;
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$is_svn = true;
	break;
	}

	$doc_href = PhabricatorEnv::getDoclink('article/Diffusion_User_Guide.html');
	$user_guide_link = phutil_tag(
	'a',
	array(
	'href' => $doc_href,
	),
	'Diffusion User Guide');

	$form = new AphrontFormView();
	$form
	->setUser($user)
	->setAction('/repository/edit/'.$repository->getID().'/tracking/')
	->appendChild(hsprintf(
	'<p class="aphront-form-instructions">Phabricator can track '.
	'repositories, importing commits as they happen and notifying '.
	'Differential, Diffusion, Herald, and other services. To enable '.
	'tracking for a repository, configure it here and then start (or '.
	'restart) the daemons. More information is available in the '.
	'<strong>%s</strong>.</p>',
	$user_guide_link));

	$form
	->appendChild(
	id(new AphrontFormInsetView())
	->setTitle('Basics')
	->appendChild(id(new AphrontFormStaticControl())
	->setLabel('Repository Name')
	->setValue($repository->getName()))
	->appendChild(id(new AphrontFormSelectControl())
	->setName('tracking')
	->setLabel('Tracking')
	->setOptions(array(
	'disabled' => 'Disabled',
	'enabled' => 'Enabled',
	))
	->setValue(
	$repository->isTracked()
	? 'enabled'
	: 'disabled')));

	$inset = new AphrontFormInsetView();
	$inset->setTitle('Remote URI');

	$clone_command = null;
	$fetch_command = null;
	if ($is_git) {
	$clone_command = 'git clone';
	$fetch_command = 'git fetch';
	} else if ($is_mercurial) {
	$clone_command = 'hg clone';
	$fetch_command = 'hg pull';
	}

	$uri_label = 'Repository URI';
	if ($has_local) {
	if ($is_git) {
	$instructions = hsprintf(
	'Enter the URI to clone this repository from. It should look like '.
	'<tt>git@github.com:example/example.git</tt>, '.
	'<tt>ssh://user@host.com/git/example.git</tt>, or '.
	'<tt>file:///local/path/to/repo</tt>');
	} else if ($is_mercurial) {
	$instructions = hsprintf(
	'Enter the URI to clone this repository from. It should look '.
	'something like <tt>ssh://user@host.com/hg/example</tt>');
	}
	$inset->appendChild(hsprintf(
	'<p class="aphront-form-instructions">%s</p>',
	$instructions));
	} else if ($is_svn) {
	$instructions = hsprintf(
	'Enter the <strong>Repository Root</strong> for this SVN repository. '.
	'You can figure this out by running <tt>svn info</tt> and looking at '.
	'the value in the <tt>Repository Root</tt> field. It should be a URI '.
	'and look like <tt>http://svn.example.org/svn/</tt>, '.
	'<tt>svn+ssh://svn.example.com/svnroot/</tt>, or '.
	'<tt>svn://svn.example.net/svn/</tt>');
	$inset->appendChild(hsprintf(
	'<p class="aphront-form-instructions">%s</p>',
	$instructions));
	$uri_label = 'Repository Root';
	}

	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('uri')
	->setLabel($uri_label)
	->setID('remote-uri')
	->setValue($repository->getDetail('remote-uri'))
	->setError($e_uri));

	+ $inset->appendChild(
	+ id(new AphrontFormCheckboxControl())
	+ ->addCheckbox(
	+ 'show-user',
	+ 1,
	+ pht('Permit users to view the username of this connection.'),
	+ $repository->getDetail('show-user') == 1));
	+
	$inset->appendChild(hsprintf(
	'<div class="aphront-form-instructions">'.
	'If you want to connect to this repository over SSH, enter the '.
	'username and private key to use. You can leave these fields blank if '.
	'the repository does not use SSH.'.
	'</div>'));

	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('ssh-login')
	->setLabel('SSH User')
	->setValue($repository->getDetail('ssh-login')))
	->appendChild(
	id(new AphrontFormTextAreaControl())
	->setName('ssh-key')
	->setLabel('SSH Private Key')
	->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
	->setValue($repository->getDetail('ssh-key'))
	->setError($e_ssh_key)
	->setCaption(
	hsprintf('Specify the entire private key, <em>or</em>...')))
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('ssh-keyfile')
	->setLabel('SSH Private Key File')
	->setValue($repository->getDetail('ssh-keyfile'))
	->setError($e_ssh_keyfile)
	->setCaption(
	'...specify a path on disk where the daemon should '.
	'look for a private key.'));

	if ($has_auth_support) {
	$inset
	->appendChild(hsprintf(
	'<div class="aphront-form-instructions">'.
	'If you want to connect to this repository with a username and '.
	'password, such as over HTTP Basic Auth or SVN with SASL, '.
	'enter the username and password to use. You can leave these '.
	'fields blank if the repository does not use a username and '.
	'password for authentication.'.
	'</div>'))
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('http-login')
	->setLabel('Username')
	->setValue($repository->getDetail('http-login')))
	->appendChild(
	id(new AphrontFormPasswordControl())
	->setName('http-pass')
	->setLabel('Password')
	->setValue($repository->getDetail('http-pass')));
	}

	$inset
	->appendChild(hsprintf(
	'<div class="aphront-form-important">'.
	'To test your authentication configuration, <strong>save this '.
	'form</strong> and then run this script:'.
	'<code>'.
	'phabricator/ $ ./scripts/repository/test_connection.php %s'.
	'</code>'.
	'This will verify that your configuration is correct and the '.
	'daemons can connect to the remote repository and pull changes '.
	'from it.'.
	'</div>',
	$repository->getCallsign()));

	$form->appendChild($inset);

	$inset = new AphrontFormInsetView();
	$inset->setTitle('Repository Information');

	if ($has_local) {
	$default_local_path = '';
	$default =
	PhabricatorEnv::getEnvConfig('repository.default-local-path');
	if (!$repository->getDetail('remote-uri') && $default) {
	$default_local_path = $default.strtolower($repository->getCallsign());
	}
	$inset->appendChild(hsprintf(
	'<p class="aphront-form-instructions">Select a path on local disk '.
	'which the daemons should <tt>%s</tt> the repository into. This must '.
	'be readable and writable by the daemons, and readable by the '.
	'webserver. The daemons will <tt>%s</tt> and keep this repository up '.
	'to date.</p>',
	$clone_command,
	$fetch_command));
	$inset->appendChild(
	id(new AphrontFormTextControl())
	->setName('path')
	->setLabel('Local Path')
	->setValue($repository->getDetail('local-path', $default_local_path))
	->setError($e_path));
	} else if ($is_svn) {
	$inset->appendChild(hsprintf(
	'<p class="aphront-form-instructions">If you only want to parse one '.
	'subpath of the repository, specify it here, relative to the '.
	'repository root (e.g., <tt>trunk/</tt> or <tt>projects/wheel/</tt>). '.
	'If you want to parse multiple subdirectories, create a separate '.
	'Phabricator repository for each one.</p>'));
	$inset->appendChild(
	id(new AphrontFormTextControl())
	->setName('svn-subpath')
	->setLabel('Subpath')
	->setValue($repository->getDetail('svn-subpath'))
	->setError($e_path));
	}

	if ($has_branch_filter) {
	$branch_filter_str = implode(
	', ',
	array_keys($repository->getDetail('branch-filter', array())));
	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('branch-filter')
	->setLabel('Track Only')
	->setValue($branch_filter_str)
	->setCaption(hsprintf(
	'Optional list of branches to track. Other branches will be '.
	'completely ignored. If left empty, all branches are tracked. '.
	'Example: <tt>master, release</tt>')));
	}

	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('frequency')
	->setLabel('Pull Frequency')
	->setValue($repository->getDetail('pull-frequency', 15))
	->setCaption(
	'Number of seconds daemon should sleep between requests. Larger '.
	'numbers reduce load but also decrease responsiveness.'));

	$form->appendChild($inset);

	$inset = new AphrontFormInsetView();
	$inset->setTitle('Application Configuration');

	if ($has_branches) {
	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('default-branch')
	->setLabel('Default Branch')
	->setValue($repository->getDefaultBranch())
	->setError($e_branch)
	->setCaption(
	'Default branch to show in Diffusion.'));
	}

	$inset
	->appendChild(id(new AphrontFormSelectControl())
	->setName('autoclose')
	->setLabel('Autoclose')
	->setOptions(array(
	'enabled' => 'Enabled: Automatically Close Pushed Revisions',
	'disabled' => 'Disabled: Ignore Pushed Revisions',
	))
	->setCaption(
	"Automatically close Differential revisions when associated commits ".
	"are pushed to this repository.")
	->setValue(
	$repository->getDetail('disable-autoclose', false)
	? 'disabled'
	: 'enabled'));

	if ($has_branch_filter) {
	$close_commits_filter_str = implode(
	', ',
	array_keys($repository->getDetail('close-commits-filter', array())));
	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('close-commits-filter')
	->setLabel('Autoclose Branches')
	->setValue($close_commits_filter_str)
	->setCaption(
	'Optional list of branches which can trigger autoclose. '.
	'If left empty, all branches trigger autoclose.'));
	}

	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('default-owners-path')
	->setLabel('Default Owners Path')
	->setValue(
	$repository->getDetail(
	'default-owners-path',
	'/'))
	->setCaption('Default path in Owners tool.'));

	$inset
	->appendChild(
	id(new AphrontFormSelectControl())
	->setName('herald-disabled')
	->setLabel('Herald/Feed Enabled')
	->setValue($repository->getDetail('herald-disabled', 0))
	->setOptions(
	array(
	0 => 'Enabled - Send Email and Publish Stories',
	1 => 'Disabled - Do Not Send Email or Publish Stories',
	))
	->setCaption(
	'You can disable Herald commit notifications and feed stories '.
	'for this repository. This can be useful when initially importing '.
	'a repository. Feed stories are never published about commits '.
	'that are more than 24 hours old.'));

	if ($is_svn) {
	$inset
	->appendChild(
	id(new AphrontFormTextControl())
	->setName('uuid')
	->setLabel('UUID')
	->setValue($repository->getUUID())
	->setCaption(hsprintf('Repository UUID from <tt>svn info</tt>.')));
	}

	$form->appendChild($inset);

	$form
	->appendChild(
	id(new AphrontFormSubmitControl())
	->setValue('Save Configuration'));

	$panel = new AphrontPanelView();
	$panel->setHeader('Repository Tracking');
	$panel->appendChild($form);
	$panel->setWidth(AphrontPanelView::WIDTH_WIDE);
	$panel->setNoBackground();

	$nav = $this->sideNav;
	$nav->appendChild($error_view);
	$nav->appendChild($panel);

	return $this->buildStandardPageResponse(
	$nav,
	array(
	'title' => 'Edit Repository Tracking',
	));
	}

	}
	diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
	index b6644a453a..ebc97a3813 100644
	--- a/src/applications/repository/storage/PhabricatorRepository.php
	+++ b/src/applications/repository/storage/PhabricatorRepository.php
	@@ -1,657 +1,661 @@
	<?php

	/**
	* @task uri Repository URI Management
	*/
	final class PhabricatorRepository extends PhabricatorRepositoryDAO
	implements PhabricatorPolicyInterface {

	/**
	* Shortest hash we'll recognize in raw "a829f32" form.
	*/
	const MINIMUM_UNQUALIFIED_HASH = 7;

	/**
	* Shortest hash we'll recognize in qualified "rXab7ef2f8" form.
	*/
	const MINIMUM_QUALIFIED_HASH = 5;

	const TABLE_PATH = 'repository_path';
	const TABLE_PATHCHANGE = 'repository_pathchange';
	const TABLE_FILESYSTEM = 'repository_filesystem';
	const TABLE_SUMMARY = 'repository_summary';
	const TABLE_BADCOMMIT = 'repository_badcommit';
	const TABLE_LINTMESSAGE = 'repository_lintmessage';

	protected $phid;
	protected $name;
	protected $callsign;
	protected $uuid;

	protected $versionControlSystem;
	protected $details = array();

	private $sshKeyfile;

	public function getConfiguration() {
	return array(
	self::CONFIG_AUX_PHID => true,
	self::CONFIG_SERIALIZATION => array(
	'details' => self::SERIALIZATION_JSON,
	),
	) + parent::getConfiguration();
	}

	public function generatePHID() {
	return PhabricatorPHID::generateNewPHID(
	PhabricatorPHIDConstants::PHID_TYPE_REPO);
	}

	public function toDictionary() {
	return array(
	'name' => $this->getName(),
	'phid' => $this->getPHID(),
	'callsign' => $this->getCallsign(),
	'vcs' => $this->getVersionControlSystem(),
	'uri' => PhabricatorEnv::getProductionURI($this->getURI()),
	'remoteURI' => (string)$this->getPublicRemoteURI(),
	'tracking' => $this->getDetail('tracking-enabled'),
	'description' => $this->getDetail('description'),
	);
	}

	public function getDetail($key, $default = null) {
	return idx($this->details, $key, $default);
	}

	public function setDetail($key, $value) {
	$this->details[$key] = $value;
	return $this;
	}

	public function getDiffusionBrowseURIForPath($path,
	$line = null,
	$branch = null) {
	$drequest = DiffusionRequest::newFromDictionary(
	array(
	'repository' => $this,
	'path' => $path,
	'branch' => $branch,
	));

	return $drequest->generateURI(
	array(
	'action' => 'browse',
	'line' => $line,
	));
	}

	public function getLocalPath() {
	return $this->getDetail('local-path');
	}

	public function execRemoteCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatRemoteCommand($args);
	return call_user_func_array('exec_manual', $args);
	}

	public function execxRemoteCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatRemoteCommand($args);
	return call_user_func_array('execx', $args);
	}

	public function getRemoteCommandFuture($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatRemoteCommand($args);
	return newv('ExecFuture', $args);
	}

	public function passthruRemoteCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatRemoteCommand($args);
	return call_user_func_array('phutil_passthru', $args);
	}

	public function execLocalCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatLocalCommand($args);
	return call_user_func_array('exec_manual', $args);
	}

	public function execxLocalCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatLocalCommand($args);
	return call_user_func_array('execx', $args);
	}

	public function getLocalCommandFuture($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatLocalCommand($args);
	return newv('ExecFuture', $args);

	}
	public function passthruLocalCommand($pattern /* , $arg, ... */) {
	$args = func_get_args();
	$args = $this->formatLocalCommand($args);
	return call_user_func_array('phutil_passthru', $args);
	}


	private function formatRemoteCommand(array $args) {
	$pattern = $args[0];
	$args = array_slice($args, 1);

	if ($this->shouldUseSSH()) {
	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$pattern = "SVN_SSH=%s svn --non-interactive {$pattern}";
	array_unshift(
	$args,
	csprintf(
	'ssh -l %s -i %s',
	$this->getSSHLogin(),
	$this->getSSHKeyfile()));
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$command = call_user_func_array(
	'csprintf',
	array_merge(
	array(
	"(ssh-add %s && git {$pattern})",
	$this->getSSHKeyfile(),
	),
	$args));
	$pattern = "ssh-agent sh -c %s";
	$args = array($command);
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$pattern = "hg --config ui.ssh=%s {$pattern}";
	array_unshift(
	$args,
	csprintf(
	'ssh -l %s -i %s',
	$this->getSSHLogin(),
	$this->getSSHKeyfile()));
	break;
	default:
	throw new Exception("Unrecognized version control system.");
	}
	} else if ($this->shouldUseHTTP()) {
	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$pattern =
	"svn ".
	"--non-interactive ".
	"--no-auth-cache ".
	"--trust-server-cert ".
	"--username %s ".
	"--password %s ".
	$pattern;
	array_unshift(
	$args,
	$this->getDetail('http-login'),
	$this->getDetail('http-pass'));
	break;
	default:
	throw new Exception(
	"No support for HTTP Basic Auth in this version control system.");
	}
	} else if ($this->shouldUseSVNProtocol()) {
	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$pattern =
	"svn ".
	"--non-interactive ".
	"--no-auth-cache ".
	"--username %s ".
	"--password %s ".
	$pattern;
	array_unshift(
	$args,
	$this->getDetail('http-login'),
	$this->getDetail('http-pass'));
	break;
	default:
	throw new Exception(
	"SVN protocol is SVN only.");
	}
	} else {
	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$pattern = "svn --non-interactive {$pattern}";
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$pattern = "git {$pattern}";
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$pattern = "hg {$pattern}";
	break;
	default:
	throw new Exception("Unrecognized version control system.");
	}
	}

	array_unshift($args, $pattern);

	return $args;
	}

	private function formatLocalCommand(array $args) {
	$pattern = $args[0];
	$args = array_slice($args, 1);

	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$pattern = "(cd %s && svn --non-interactive {$pattern})";
	array_unshift($args, $this->getLocalPath());
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$pattern = "(cd %s && git {$pattern})";
	array_unshift($args, $this->getLocalPath());
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$pattern = "(cd %s && HGPLAIN=1 hg {$pattern})";
	array_unshift($args, $this->getLocalPath());
	break;
	default:
	throw new Exception("Unrecognized version control system.");
	}

	array_unshift($args, $pattern);

	return $args;
	}

	private function getSSHLogin() {
	return $this->getDetail('ssh-login');
	}

	private function getSSHKeyfile() {
	if ($this->sshKeyfile === null) {
	$key = $this->getDetail('ssh-key');
	$keyfile = $this->getDetail('ssh-keyfile');
	if ($keyfile) {
	// Make sure we can read the file, that it exists, etc.
	Filesystem::readFile($keyfile);
	$this->sshKeyfile = $keyfile;
	} else if ($key) {
	$keyfile = new TempFile('phabricator-repository-ssh-key');
	chmod($keyfile, 0600);
	Filesystem::writeFile($keyfile, $key);
	$this->sshKeyfile = $keyfile;
	} else {
	$this->sshKeyfile = '';
	}
	}

	return (string)$this->sshKeyfile;
	}

	public function getURI() {
	return '/diffusion/'.$this->getCallsign().'/';
	}

	public function isTracked() {
	return $this->getDetail('tracking-enabled', false);
	}

	public function getDefaultBranch() {
	$default = $this->getDetail('default-branch');
	if (strlen($default)) {
	return $default;
	}

	$default_branches = array(
	PhabricatorRepositoryType::REPOSITORY_TYPE_GIT => 'master',
	PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL => 'default',
	);

	return idx($default_branches, $this->getVersionControlSystem());
	}

	public function getDefaultArcanistBranch() {
	return coalesce($this->getDefaultBranch(), 'svn');
	}

	private function isBranchInFilter($branch, $filter_key) {
	$vcs = $this->getVersionControlSystem();

	$is_git = ($vcs == PhabricatorRepositoryType::REPOSITORY_TYPE_GIT);

	$use_filter = ($is_git);

	if ($use_filter) {
	$filter = $this->getDetail($filter_key, array());
	if ($filter && empty($filter[$branch])) {
	return false;
	}
	}

	// By default, all branches pass.
	return true;
	}

	public function shouldTrackBranch($branch) {
	return $this->isBranchInFilter($branch, 'branch-filter');
	}

	public function shouldAutocloseBranch($branch) {
	if ($this->getDetail('disable-autoclose', false)) {
	return false;
	}

	return $this->isBranchInFilter($branch, 'close-commits-filter');
	}

	public function shouldAutocloseCommit(
	PhabricatorRepositoryCommit $commit,
	PhabricatorRepositoryCommitData $data) {

	if ($this->getDetail('disable-autoclose', false)) {
	return false;
	}

	switch ($this->getVersionControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	return true;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	return true;
	default:
	throw new Exception("Unrecognized version control system.");
	}

	$branches = $data->getCommitDetail('seenOnBranches', array());
	foreach ($branches as $branch) {
	if ($this->shouldAutocloseBranch($branch)) {
	return true;
	}
	}

	return false;
	}

	public function formatCommitName($commit_identifier) {
	$vcs = $this->getVersionControlSystem();

	$type_git = PhabricatorRepositoryType::REPOSITORY_TYPE_GIT;
	$type_hg = PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL;

	$is_git = ($vcs == $type_git);
	$is_hg = ($vcs == $type_hg);
	if ($is_git \|\| $is_hg) {
	$short_identifier = substr($commit_identifier, 0, 12);
	} else {
	$short_identifier = $commit_identifier;
	}

	return 'r'.$this->getCallsign().$short_identifier;
	}

	public static function loadAllByPHIDOrCallsign(array $names) {
	$repositories = array();
	foreach ($names as $name) {
	$repo = id(new PhabricatorRepository())->loadOneWhere(
	'phid = %s OR callsign = %s',
	$name,
	$name);
	if (!$repo) {
	throw new Exception(
	"No repository with PHID or callsign '{$name}' exists!");
	}
	$repositories[$repo->getID()] = $repo;
	}
	return $repositories;
	}

	/* -( Repository URI Management )------------------------------------------ */


	/**
	* Get the remote URI for this repository.
	*
	* @return string
	* @task uri
	*/
	public function getRemoteURI() {
	return (string)$this->getRemoteURIObject();
	}


	/**
	* Get the remote URI for this repository, without authentication information.
	*
	* @return string Repository URI.
	* @task uri
	*/
	public function getPublicRemoteURI() {
	$uri = $this->getRemoteURIObject();

	// Make sure we don't leak anything if this repo is using HTTP Basic Auth
	// with the credentials in the URI or something zany like that.

	if ($uri instanceof PhutilGitURI) {
	- $uri->setUser(null);
	+ if (!$this->getDetail('show-user', false)) {
	+ $uri->setUser(null);
	+ }
	} else {
	- $uri->setUser(null);
	+ if (!$this->getDetail('show-user', false)) {
	+ $uri->setUser(null);
	+ }
	$uri->setPass(null);
	}

	return (string)$uri;
	}


	/**
	* Get the protocol for the repository's remote.
	*
	* @return string Protocol, like "ssh" or "git".
	* @task uri
	*/
	public function getRemoteProtocol() {
	$uri = $this->getRemoteURIObject();

	if ($uri instanceof PhutilGitURI) {
	return 'ssh';
	} else {
	return $uri->getProtocol();
	}
	}


	/**
	* Get a parsed object representation of the repository's remote URI. This
	* may be a normal URI (returned as a @{class@libphutil:PhutilURI}) or a git
	* URI (returned as a @{class@libphutil:PhutilGitURI}).
	*
	* @return wild A @{class@libphutil:PhutilURI} or
	* @{class@libphutil:PhutilGitURI}.
	* @task uri
	*/
	private function getRemoteURIObject() {
	$raw_uri = $this->getDetail('remote-uri');
	if (!$raw_uri) {
	return new PhutilURI('');
	}

	if (!strncmp($raw_uri, '/', 1)) {
	return new PhutilURI('file://'.$raw_uri);
	}

	$uri = new PhutilURI($raw_uri);
	if ($uri->getProtocol()) {
	if ($this->isSSHProtocol($uri->getProtocol())) {
	if ($this->getSSHLogin()) {
	$uri->setUser($this->getSSHLogin());
	}
	}
	return $uri;
	}

	$uri = new PhutilGitURI($raw_uri);
	if ($uri->getDomain()) {
	if ($this->getSSHLogin()) {
	$uri->setUser($this->getSSHLogin());
	}
	return $uri;
	}

	throw new Exception("Remote URI '{$raw_uri}' could not be parsed!");
	}


	/**
	* Determine if we should connect to the remote using SSH flags and
	* credentials.
	*
	* @return bool True to use the SSH protocol.
	* @task uri
	*/
	private function shouldUseSSH() {
	$protocol = $this->getRemoteProtocol();
	if ($this->isSSHProtocol($protocol)) {
	return (bool)$this->getSSHKeyfile();
	} else {
	return false;
	}
	}


	/**
	* Determine if we should connect to the remote using HTTP flags and
	* credentials.
	*
	* @return bool True to use the HTTP protocol.
	* @task uri
	*/
	private function shouldUseHTTP() {
	$protocol = $this->getRemoteProtocol();
	if ($protocol == 'http' \|\| $protocol == 'https') {
	return (bool)$this->getDetail('http-login');
	} else {
	return false;
	}
	}


	/**
	* Determine if we should connect to the remote using SVN flags and
	* credentials.
	*
	* @return bool True to use the SVN protocol.
	* @task uri
	*/
	private function shouldUseSVNProtocol() {
	$protocol = $this->getRemoteProtocol();
	if ($protocol == 'svn') {
	return (bool)$this->getDetail('http-login');
	} else {
	return false;
	}
	}


	/**
	* Determine if a protocol is SSH or SSH-like.
	*
	* @param string A protocol string, like "http" or "ssh".
	* @return bool True if the protocol is SSH-like.
	* @task uri
	*/
	private function isSSHProtocol($protocol) {
	return ($protocol == 'ssh' \|\| $protocol == 'svn+ssh');
	}

	public function delete() {
	$this->openTransaction();

	$paths = id(new PhabricatorOwnersPath())
	->loadAllWhere('repositoryPHID = %s', $this->getPHID());
	foreach ($paths as $path) {
	$path->delete();
	}

	$projects = id(new PhabricatorRepositoryArcanistProject())
	->loadAllWhere('repositoryID = %d', $this->getID());
	foreach ($projects as $project) {
	// note each project deletes its PhabricatorRepositorySymbols
	$project->delete();
	}

	$commits = id(new PhabricatorRepositoryCommit())
	->loadAllWhere('repositoryID = %d', $this->getID());
	foreach ($commits as $commit) {
	// note PhabricatorRepositoryAuditRequests and
	// PhabricatorRepositoryCommitData are deleted here too.
	$commit->delete();
	}

	$conn_w = $this->establishConnection('w');

	queryfx(
	$conn_w,
	'DELETE FROM %T WHERE repositoryID = %d',
	self::TABLE_FILESYSTEM,
	$this->getID());

	queryfx(
	$conn_w,
	'DELETE FROM %T WHERE repositoryID = %d',
	self::TABLE_PATHCHANGE,
	$this->getID());

	queryfx(
	$conn_w,
	'DELETE FROM %T WHERE repositoryID = %d',
	self::TABLE_SUMMARY,
	$this->getID());

	$result = parent::delete();

	$this->saveTransaction();
	return $result;
	}

	public function isGit() {
	$vcs = $this->getVersionControlSystem();
	return ($vcs == PhabricatorRepositoryType::REPOSITORY_TYPE_GIT);
	}

	public function isSVN() {
	$vcs = $this->getVersionControlSystem();
	return ($vcs == PhabricatorRepositoryType::REPOSITORY_TYPE_SVN);
	}

	public function isHg() {
	$vcs = $this->getVersionControlSystem();
	return ($vcs == PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL);
	}



	/* -( PhabricatorPolicyInterface )----------------------------------------- */


	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,
	);
	}

	public function getPolicy($capability) {
	switch ($capability) {
	case PhabricatorPolicyCapability::CAN_VIEW:
	return PhabricatorPolicies::POLICY_USER;
	case PhabricatorPolicyCapability::CAN_EDIT:
	return PhabricatorPolicies::POLICY_ADMIN;
	}
	}

	public function hasAutomaticCapability($capability, PhabricatorUser $user) {
	return false;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 18:48 (1 w, 4 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1127553
Default Alt Text: (43 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions