View Options

	diff --git a/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php b/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
	index 7fba83c15d..cb6237bbd1 100644
	--- a/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
	+++ b/src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
	@@ -1,139 +1,139 @@
	<?php

	/**
	* @group conduit
	*/
	final class ConduitAPI_repository_create_Method
	extends ConduitAPI_repository_Method {

	public function getMethodStatus() {
	return self::METHOD_STATUS_UNSTABLE;
	}

	public function getMethodStatusDescription() {
	return "Repository methods are new and subject to change.";
	}

	public function getMethodDescription() {
	return "Create a new repository (Admin Only).";
	}

	public function defineParamTypes() {
	return array(
	'name' => 'required string',
	'vcs' => 'required enum<git, hg, svn>',
	'callsign' => 'required string',
	'description' => 'optional string',
	'encoding' => 'optional string',
	'tracking' => 'optional bool',
	'uri' => 'optional string',
	'sshUser' => 'optional string',
	'sshKey' => 'optional string',
	'sshKeyFile' => 'optional string',
	'httpUser' => 'optional string',
	'httpPassword' => 'optional string',
	'localPath' => 'optional string',
	'svnSubpath' => 'optional string',
	'branchFilter' => 'optional list<string>',
	'closeCommitsFilter' => 'optional list<string>',
	'pullFrequency' => 'optional int',
	'defaultBranch' => 'optional string',
	'heraldEnabled' => 'optional bool, default = true',
	'autocloseEnabled' => 'optional bool, default = true',
	'svnUUID' => 'optional string',
	);
	}

	public function defineReturnType() {
	return 'nonempty dict';
	}

	public function defineErrorTypes() {
	return array(
	'ERR-PERMISSIONS' =>
	'You do not have the authority to call this method.',
	'ERR-DUPLICATE' =>
	'Duplicate repository callsign.',
	'ERR-BAD-CALLSIGN' =>
	'Callsign is required and must be ALL UPPERCASE LETTERS.',
	'ERR-UNKNOWN-REPOSITORY-VCS' =>
	'Unknown repository VCS type.',
	);
	}

	protected function execute(ConduitAPIRequest $request) {
	$application = id(new PhabricatorApplicationQuery())
	->setViewer($request->getUser())
	->withClasses(array('PhabricatorApplicationDiffusion'))
	->executeOne();

	PhabricatorPolicyFilter::requireCapability(
	$request->getUser(),
	$application,
	DiffusionCapabilityCreateRepositories::CAPABILITY);

	// TODO: This has some duplication with (and lacks some of the validation
	// of) the web workflow; refactor things so they can share more code as this
	// stabilizes. Specifically, this should move to transactions since they
	// work properly now.

	$repository = PhabricatorRepository::initializeNewRepository(
	$request->getUser());

	$repository->setName($request->getValue('name'));

	$callsign = $request->getValue('callsign');
	- if (!preg_match('/[A-Z]+$/', $callsign)) {
	+ if (!preg_match('/^[A-Z]+$/', $callsign)) {
	throw new ConduitException('ERR-BAD-CALLSIGN');
	}
	$repository->setCallsign($callsign);

	$vcs = $request->getValue('vcs');

	$map = array(
	'git' => PhabricatorRepositoryType::REPOSITORY_TYPE_GIT,
	'hg' => PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL,
	'svn' => PhabricatorRepositoryType::REPOSITORY_TYPE_SVN,
	);
	if (empty($map[$vcs])) {
	throw new ConduitException('ERR-UNKNOWN-REPOSITORY-VCS');
	}
	$repository->setVersionControlSystem($map[$vcs]);

	$details = array(
	'encoding' => $request->getValue('encoding'),
	'description' => $request->getValue('description'),
	'tracking-enabled' => (bool)$request->getValue('tracking', true),
	'remote-uri' => $request->getValue('uri'),
	'local-path' => $request->getValue('localPath'),
	'branch-filter' => array_fill_keys(
	$request->getValue('branchFilter', array()),
	true),
	'close-commits-filter' => array_fill_keys(
	$request->getValue('closeCommitsFilter', array()),
	true),
	'pull-frequency' => $request->getValue('pullFrequency'),
	'default-branch' => $request->getValue('defaultBranch'),
	'ssh-login' => $request->getValue('sshUser'),
	'ssh-key' => $request->getValue('sshKey'),
	'ssh-keyfile' => $request->getValue('sshKeyFile'),
	'herald-disabled' => !$request->getValue('heraldEnabled', true),
	'svn-subpath' => $request->getValue('svnSubpath'),
	'disable-autoclose' => !$request->getValue('autocloseEnabled', true),
	);

	foreach ($details as $key => $value) {
	$repository->setDetail($key, $value);
	}

	try {
	$repository->save();
	} catch (AphrontQueryDuplicateKeyException $ex) {
	throw new ConduitException('ERR-DUPLICATE');
	}

	return $repository->toDictionary();
	}


	}

File Metadata

Mime Type: text/x-diff
Expires: Jan 19 2025, 17:37 (6 w, 20 h ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1127035
Default Alt Text: (5 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions