View Options

	diff --git a/src/applications/diffusion/query/diff/DiffusionGitDiffQuery.php b/src/applications/diffusion/query/diff/DiffusionGitDiffQuery.php
	index 550d1c96b7..73446cc958 100644
	--- a/src/applications/diffusion/query/diff/DiffusionGitDiffQuery.php
	+++ b/src/applications/diffusion/query/diff/DiffusionGitDiffQuery.php
	@@ -1,61 +1,61 @@
	<?php

	/*
	* Copyright 2012 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	final class DiffusionGitDiffQuery extends DiffusionDiffQuery {

	protected function executeQuery() {
	$drequest = $this->getRequest();
	$repository = $drequest->getRepository();

	$effective_commit = $this->getEffectiveCommit();
	if (!$effective_commit) {
	return null;
	}
	- // TODO: This side effect is kind of skethcy.
	+ // TODO: This side effect is kind of sketchy.
	$drequest->setCommit($effective_commit);

	$raw_query = DiffusionRawDiffQuery::newFromDiffusionRequest($drequest);
	$raw_diff = $raw_query->loadRawDiff();

	if (!$raw_diff) {
	return null;
	}

	$parser = new ArcanistDiffParser();

	$try_encoding = $repository->getDetail('encoding');
	if ($try_encoding) {
	$parser->setTryEncoding($try_encoding);
	}

	$parser->setDetectBinaryFiles(true);
	$changes = $parser->parseDiff($raw_diff);

	$diff = DifferentialDiff::newFromRawChanges($changes);
	$changesets = $diff->getChangesets();
	$changeset = reset($changesets);

	$this->renderingReference = $drequest->generateURI(
	array(
	'action' => 'rendering-ref',
	));

	return $changeset;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 16:43 (2 w, 5 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1126604
Default Alt Text: (2 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions