Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2892379
D25596.1737218580.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
876 B
Referenced Files
None
Subscribers
None
D25596.1737218580.diff
View Options
diff --git a/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php b/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php
--- a/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php
+++ b/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php
@@ -38,7 +38,7 @@
}
}
- if (strlen($value) && !$seen) {
+ if (phutil_nonempty_string($value) && !$seen) {
$name = pht('Custom Query ("%s")', $value);
} else {
$name = pht('(None)');
@@ -56,7 +56,7 @@
'queryID' => $control_id,
'options' => $queries,
'value' => array(
- 'key' => strlen($value) ? $value : null,
+ 'key' => phutil_nonempty_string($value) ? $value : null,
'name' => $name,
),
));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 18, 16:43 (11 h, 49 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1116122
Default Alt Text
D25596.1737218580.diff (876 B)
Attached To
Mode
D25596: Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined
Attached
Detach File
Event Timeline
Log In to Comment