Page MenuHomePhorge

No OneTemporary

diff --git a/src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php b/src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php
index efebd12c6f..a83829ccc4 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryDefaultController.php
@@ -1,25 +1,34 @@
<?php
final class DiffusionRepositoryDefaultController extends DiffusionController {
+ public function shouldAllowPublic() {
+ // NOTE: We allow public access to this controller because it handles
+ // redirecting paths that are missing a trailing "/". We need to manually
+ // redirect these instead of relying on the automatic redirect because
+ // some VCS requests may omit the slashes. See T12035, and below, for some
+ // discussion.
+ return true;
+ }
+
public function handleRequest(AphrontRequest $request) {
$response = $this->loadDiffusionContext();
if ($response) {
return $response;
}
// NOTE: This controller is just here to make sure we call
// willBeginExecution() on any /diffusion/X/ URI, so we can intercept
// `git`, `hg` and `svn` HTTP protocol requests.
// If we made it here, it's probably because the user copy-pasted a
// clone URI with "/anything.git" at the end into their web browser.
// Send them to the canonical repository URI.
$drequest = $this->getDiffusionRequest();
$repository = $drequest->getRepository();
return id(new AphrontRedirectResponse())
->setURI($repository->getURI());
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sun, Jan 19, 16:01 (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1126288
Default Alt Text
(1 KB)

Event Timeline